Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump docker dependency #1067

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Bump docker dependency #1067

merged 1 commit into from
Aug 31, 2023

Conversation

xpivarc
Copy link
Member

@xpivarc xpivarc commented Aug 4, 2023

Fix a "invalid Host Header" error with
few Go versions

@kubevirt-bot kubevirt-bot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Aug 4, 2023
brianmcarey
brianmcarey reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@xpivarc could you sign your commit?

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@xpivarc
Bump docker dependency
45f25e3 
Fix a "invalid Host Header" error with
few Go versions

Signed-off-by: Luboslav Pivarc <lpivarc@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed lgtm Indicates that a PR is ready to be merged. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Aug 8, 2023
@xpivarc
Copy link
Member Author

xpivarc commented Aug 8, 2023

@brianmcarey Done, thanks!

brianmcarey
brianmcarey approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@brianmcarey
Copy link
Member

/retest-required

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Aug 31, 2023 •
edited
Loading

@xpivarc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.27-vgpu 45f25e3 link false /test check-up-kind-1.27-vgpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 7a80619 into kubevirt:main Aug 31, 2023
7 checks passed
@brianmcarey
Copy link
Member

@xpivarc - it looks like this change broke the publish job - https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/publish-kubevirtci/1697339447776907264

Not sure how it wasn't caught by the check-provisions?

@xpivarc
Copy link
Member Author

xpivarc commented Sep 1, 2023

@xpivarc - it looks like this change broke the publish job - https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/publish-kubevirtci/1697339447776907264

Not sure how it wasn't caught by the check-provisions?

I am not quite sure as well. Let's revert or fix.

@brianmcarey brianmcarey mentioned this pull request Sep 1, 2023
Merged
brianmcarey added a commit to brianmcarey/kubevirtci that referenced this pull request Sep 1, 2023
@brianmcarey
Revert "Bump docker dependency (kubevirt#1067)"
1c148d2 
This change caused the kubevirtci publish to fail - reverting for now to
allow for other changes to go in.

This reverts commit 7a80619.

Signed-off-by: Brian Carey <bcarey@redhat.com>
@dhiller
Copy link
Contributor

dhiller commented Sep 1, 2023

@xpivarc - it looks like this change broke the publish job - https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/publish-kubevirtci/1697339447776907264
Not sure how it wasn't caught by the check-provisions?

I am not quite sure as well. Let's revert or fix.

I think that this looks like a quite old go version, no? Maybe rather update that one?

@oshoval
Copy link
Contributor

oshoval commented Sep 3, 2023 •
edited
Loading

Not sure how it wasn't caught by the check-provisions?

publish is only postsubmit, check-provision is only presubmit, flow might be different
(or maybe the image etc)

@kubevirt-bot kubevirt-bot mentioned this pull request Sep 4, 2023
Merged
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Sep 4, 2023
@kubevirt-bot
Bump kubevirtci
316d5c6 
[7a80619 Bump docker dependency](kubevirt/kubevirtci#1067)
[beb5872 Increase default disk size to avoid node disk pressure](kubevirt/kubevirtci#1072)
[27b06cb Pin to earlier versions of vmlinuz and initrd.img due to issue with](kubevirt/kubevirtci#1075)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Sep 5, 2023
@kubevirt-bot
Bump kubevirtci
4ac515c 
[52483da Downgrade k8s-1.27 to 1.27.1](kubevirt/kubevirtci#1077)
[7a80619 Bump docker dependency](kubevirt/kubevirtci#1067)
[beb5872 Increase default disk size to avoid node disk pressure](kubevirt/kubevirtci#1072)
[27b06cb Pin to earlier versions of vmlinuz and initrd.img due to issue with](kubevirt/kubevirtci#1075)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
@oshoval
Copy link
Contributor

oshoval commented Sep 10, 2023

Please note that this PR cause problems when i try to spin cluster locally,
building without it locally fixed the problem

more info
kubevirt/kubevirt#10375 (comment)

@brianmcarey
Copy link
Member

Please note that this PR cause problems when i try to spin cluster locally, building without it locally fixed the problem

more info kubevirt/kubevirt#10375 (comment)

@oshoval are you trying this in podman or docker?

@oshoval
Copy link
Contributor

oshoval commented Sep 11, 2023 •
edited
Loading

Please note that this PR cause problems when i try to spin cluster locally, building without it locally fixed the problem
more info kubevirt/kubevirt#10375 (comment)

@oshoval are you trying this in podman or docker?

pure docker, also the rebuilt with docker
as we spoke offline, the fact we moved to podman build, allows it to run only on podman
we had it in the past, i think we should update go and use docker build atm please
with docker build both podman and docker able to run it, but not with podman build

@kubevirt-bot kubevirt-bot mentioned this pull request Sep 12, 2023
Merged
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Sep 12, 2023
@kubevirt-bot
Bump kubevirtci
2cdbc26 
[52483da Downgrade k8s-1.27 to 1.27.1](kubevirt/kubevirtci#1077)
[7a80619 Bump docker dependency](kubevirt/kubevirtci#1067)
[beb5872 Increase default disk size to avoid node disk pressure](kubevirt/kubevirtci#1072)
[27b06cb Pin to earlier versions of vmlinuz and initrd.img due to issue with](kubevirt/kubevirtci#1075)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Sep 13, 2023
@kubevirt-bot
Bump kubevirtci
34d1e38 
[ece7e87 Remove the pinning of CentOS Stream kernel version](kubevirt/kubevirtci#1080)
[52483da Downgrade k8s-1.27 to 1.27.1](kubevirt/kubevirtci#1077)
[7a80619 Bump docker dependency](kubevirt/kubevirtci#1067)
[beb5872 Increase default disk size to avoid node disk pressure](kubevirt/kubevirtci#1072)
[27b06cb Pin to earlier versions of vmlinuz and initrd.img due to issue with](kubevirt/kubevirtci#1075)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
VirrageS pushed a commit to VirrageS/kubevirt that referenced this pull request Nov 17, 2023
@kubevirt-bot @VirrageS
Bump kubevirtci
e2fb30a 
[52483da Downgrade k8s-1.27 to 1.27.1](kubevirt/kubevirtci#1077)
[7a80619 Bump docker dependency](kubevirt/kubevirtci#1067)
[beb5872 Increase default disk size to avoid node disk pressure](kubevirt/kubevirtci#1072)
[27b06cb Pin to earlier versions of vmlinuz and initrd.img due to issue with](kubevirt/kubevirtci#1075)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
VirrageS pushed a commit to VirrageS/kubevirt that referenced this pull request Nov 17, 2023
@kubevirt-bot @VirrageS
Bump kubevirtci
6ae17f1 
[ece7e87 Remove the pinning of CentOS Stream kernel version](kubevirt/kubevirtci#1080)
[52483da Downgrade k8s-1.27 to 1.27.1](kubevirt/kubevirtci#1077)
[7a80619 Bump docker dependency](kubevirt/kubevirtci#1067)
[beb5872 Increase default disk size to avoid node disk pressure](kubevirt/kubevirtci#1072)
[27b06cb Pin to earlier versions of vmlinuz and initrd.img due to issue with](kubevirt/kubevirtci#1075)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey brianmcarey approved these changes

@davidvossel davidvossel Awaiting requested review from davidvossel

@oshoval oshoval Awaiting requested review from oshoval

Assignees

@brianmcarey brianmcarey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xpivarc @kubevirt-bot @brianmcarey @kubevirt-commenter-bot @dhiller @oshoval