Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the pinning of CentOS Stream kernel version #1080

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

brianmcarey
Copy link
Member

@brianmcarey brianmcarey commented Sep 6, 2023

The latest kernel should have the shutdown issue resolved.

Includes update to CentOS Stream 9 image to 20230821.0

#1075

The latest kernel should have the shutdown issue resolved.

Signed-off-by: Brian Carey <bcarey@redhat.com>
@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Sep 6, 2023
@brianmcarey
Copy link
Member Author

/test check-provision-k8s-1.27

@akalenyu
Copy link
Contributor

akalenyu commented Sep 6, 2023

Aren't we using an older centos image though?

@brianmcarey
Copy link
Member Author

Aren't we using an older centos image though?

Yes you are right. I will try to upgrade the image too.

The kernel is always latest as it comes from here though - https://github.com/kubevirt/kubevirtci/pull/1080/files#diff-b5f457593536f8e24487be424871b5403701dde944795ba4d06c73fbb29c17edR31

Signed-off-by: Brian Carey <bcarey@redhat.com>
@brianmcarey
Copy link
Member Author

/test check-provision-k8s-1.27

@akalenyu
Copy link
Contributor

akalenyu commented Sep 6, 2023

Aren't we using an older centos image though?

Yes you are right. I will try to upgrade the image too.

The kernel is always latest as it comes from here though - https://github.com/kubevirt/kubevirtci/pull/1080/files#diff-b5f457593536f8e24487be424871b5403701dde944795ba4d06c73fbb29c17edR31

Are you sure? I was sitting on CDI main and we had 5.14.0-289.el9.x86_64 on the node
and kubevirtci version https://github.com/kubevirt/kubevirtci/releases/tag/2303311039-054c0ed

@brianmcarey
Copy link
Member Author

Aren't we using an older centos image though?

Yes you are right. I will try to upgrade the image too.
The kernel is always latest as it comes from here though - https://github.com/kubevirt/kubevirtci/pull/1080/files#diff-b5f457593536f8e24487be424871b5403701dde944795ba4d06c73fbb29c17edR31

Are you sure? I was sitting on CDI main and we had 5.14.0-289.el9.x86_64 on the node and kubevirtci version https://github.com/kubevirt/kubevirtci/releases/tag/2303311039-054c0ed

Sorry latest kernel at publishing time. 5.14.0-289.el9.x86_64 would of been the latest when that tag was published.

@akalenyu
Copy link
Contributor

akalenyu commented Sep 6, 2023

Aren't we using an older centos image though?

Yes you are right. I will try to upgrade the image too.
The kernel is always latest as it comes from here though - https://github.com/kubevirt/kubevirtci/pull/1080/files#diff-b5f457593536f8e24487be424871b5403701dde944795ba4d06c73fbb29c17edR31

Are you sure? I was sitting on CDI main and we had 5.14.0-289.el9.x86_64 on the node and kubevirtci version https://github.com/kubevirt/kubevirtci/releases/tag/2303311039-054c0ed

Sorry latest kernel at publishing time. 5.14.0-289.el9.x86_64 would of been the latest when that tag was published.

Ohh right my bad

@@ -27,11 +27,7 @@ ENV CENTOS_URL https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Str

RUN /download_box.sh ${CENTOS_URL}

# Pin to earlier versions of vmlinuz & initrd.img due to issue with latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should include this information inside some troubleshooting document, including a reference to the commit, so that we can apply this again if required.

This could also be done for other workarounds we had to do.

@brianmcarey
Copy link
Member Author

/test check-provision-k8s-1.27

4 similar comments
@brianmcarey
Copy link
Member Author

/test check-provision-k8s-1.27

@brianmcarey
Copy link
Member Author

/test check-provision-k8s-1.27

@brianmcarey
Copy link
Member Author

/test check-provision-k8s-1.27

@brianmcarey
Copy link
Member Author

/test check-provision-k8s-1.27

@brianmcarey brianmcarey marked this pull request as ready for review September 13, 2023 07:12
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2023
@brianmcarey
Copy link
Member Author

/cc @xpivarc

This needs to be merged to unblock the publish of kubevirtci.

@kubevirt-bot
Copy link
Contributor

@brianmcarey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.27-vgpu 23b9a35 link false /test check-up-kind-1.27-vgpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
Copy link
Member Author

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xpivarc thank you!

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@kubevirt-bot kubevirt-bot merged commit ece7e87 into kubevirt:main Sep 13, 2023
8 of 9 checks passed
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Sep 13, 2023
[ece7e87 Remove the pinning of CentOS Stream kernel version](kubevirt/kubevirtci#1080)
[52483da Downgrade k8s-1.27 to 1.27.1](kubevirt/kubevirtci#1077)
[7a80619 Bump docker dependency](kubevirt/kubevirtci#1067)
[beb5872 Increase default disk size to avoid node disk pressure](kubevirt/kubevirtci#1072)
[27b06cb Pin to earlier versions of vmlinuz and initrd.img due to issue with](kubevirt/kubevirtci#1075)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
VirrageS pushed a commit to VirrageS/kubevirt that referenced this pull request Nov 17, 2023
[ece7e87 Remove the pinning of CentOS Stream kernel version](kubevirt/kubevirtci#1080)
[52483da Downgrade k8s-1.27 to 1.27.1](kubevirt/kubevirtci#1077)
[7a80619 Bump docker dependency](kubevirt/kubevirtci#1067)
[beb5872 Increase default disk size to avoid node disk pressure](kubevirt/kubevirtci#1072)
[27b06cb Pin to earlier versions of vmlinuz and initrd.img due to issue with](kubevirt/kubevirtci#1075)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants