Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update golang in CI to 1.20 #777

Merged
merged 1 commit into from
Dec 5, 2023
Merged

chore: Update golang in CI to 1.20 #777

merged 1 commit into from
Dec 5, 2023

Conversation

akrejcir
Copy link
Collaborator

@akrejcir akrejcir commented Dec 5, 2023

What this PR does / why we need it:
Updated ci-builder container and GitHub actions to use golang 1.20.

Special notes for your reviewer:
This PR is a prerequisite for: #745
Because the CI uses the ci-builder container from the current HEAD, not from the PR: https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image

Release note:

None

@akrejcir
chore: Update golang in CI to 1.20
dc0aa95 
Updated ci-builder container and GitHub actions
to use golang 1.20.

This commit needs to be merged before we can move
other parts of code to 1.20.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 5, 2023
@akrejcir
Copy link
Collaborator Author

akrejcir commented Dec 5, 2023

/cc @0xFelix @ksimon1

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ksimon1
Copy link
Member

ksimon1 commented Dec 5, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
@ksimon1
Copy link
Member

ksimon1 commented Dec 5, 2023

btw. what about https://github.com/kubevirt/ssp-operator/blob/main/Dockerfile and https://github.com/kubevirt/ssp-operator/blob/main/validator.Dockerfile#L4?

@akrejcir
Copy link
Collaborator Author

akrejcir commented Dec 5, 2023

Those 2 will be updated in the other PR. This PR only updates for CI and GitHub Actions.

@akrejcir
Copy link
Collaborator Author

akrejcir commented Dec 5, 2023

Overriding CI, because the changed ci-builder container is not checked by CI in this PR.

/override ci/prow/e2e-functests ci/prow/e2e-single-node-functests ci/prow/e2e-upgrade-functests

@kubevirt-bot
Copy link
Contributor

@akrejcir: Overrode contexts on behalf of akrejcir: ci/prow/e2e-functests, ci/prow/e2e-single-node-functests, ci/prow/e2e-upgrade-functests

In response to this:

Overriding CI, because the changed ci-builder container is not checked by CI in this PR.

/override ci/prow/e2e-functests ci/prow/e2e-single-node-functests ci/prow/e2e-upgrade-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akrejcir
Copy link
Collaborator Author

akrejcir commented Dec 5, 2023

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@kubevirt-bot kubevirt-bot merged commit d90afe7 into kubevirt:main Dec 5, 2023
4 checks passed
@akrejcir akrejcir deleted the update-golang-ci branch December 5, 2023 16:32
0xFelix
0xFelix reviewed Dec 6, 2023
View reviewed changes
.github/workflows/pull-request.yaml
uses: actions/setup-go@v2
with:
go-version: '1.19'
go-version: '1.20'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action also supports getting the golang version from the go.mod file. That might be an alternative?

See https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@codingben codingben Awaiting requested review from codingben

@jcanocan jcanocan Awaiting requested review from jcanocan

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akrejcir @ksimon1 @kubevirt-bot @0xFelix