Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update golang in CI to 1.20 #777

Merged
merged 1 commit into from
Dec 5, 2023
Merged

chore: Update golang in CI to 1.20 #777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/pull-request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
validate_metrics_docs:
runs-on: ubuntu-latest
steps:
- name: Install Golang 1.19
- name: Install Golang 1.20
uses: actions/setup-go@v2
with:
go-version: '1.19'
go-version: '1.20'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action also supports getting the golang version from the go.mod file. That might be an alternative?

See https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the information.

- name: Checkout code
uses: actions/checkout@v3
- name: Generate metrics docs
Expand All @@ -22,10 +22,10 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Install Golang 1.19
- name: Install Golang 1.20
uses: actions/setup-go@v2
with:
go-version: '1.19'
go-version: '1.20'

- name: Checkout code
uses: actions/checkout@v2
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ jobs:
name: Upload Release Asset
runs-on: ubuntu-latest
steps:
- name: Install Golang 1.19
- name: Install Golang 1.20
uses: actions/setup-go@v2
with:
go-version: '1.19'
go-version: '1.20'

- name: Checkout code
uses: actions/checkout@v2
Expand All @@ -32,7 +32,7 @@ jobs:
make release

- name: Upload CRD Asset
id: upload-crd-asset
id: upload-crd-asset
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.ACTIONS_TOKEN }}
Expand All @@ -43,7 +43,7 @@ jobs:
asset_content_type: text/plain

- name: Upload CSV Asset
id: upload-csv-asset
id: upload-csv-asset
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.ACTIONS_TOKEN }}
Expand All @@ -54,7 +54,7 @@ jobs:
asset_content_type: text/plain

- name: Upload Operator Asset
id: upload-operator-asset
id: upload-operator-asset
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.ACTIONS_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion ci-builder/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This Dockerfile is used in openshift CI
FROM quay.io/fedora/fedora:37

RUN curl -L https://go.dev/dl/go1.19.2.linux-amd64.tar.gz | tar -C /usr/local -xzf -
RUN curl -L https://go.dev/dl/go1.20.11.linux-amd64.tar.gz | tar -C /usr/local -xzf -
ENV PATH=$PATH:/usr/local/go/bin

# Install dependencies and tools
Expand Down
Loading