Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policies.yaml should match CRDs: rename url field to module. #906

Closed
fabriziosestito opened this issue Sep 16, 2024 · 0 comments · Fixed by #1016 or kubewarden/kubewarden-controller#952
Closed

policies.yaml should match CRDs: rename url field to module. #906

fabriziosestito opened this issue Sep 16, 2024 · 0 comments · Fixed by #1016 or kubewarden/kubewarden-controller#952
Assignees
@jvanz
Labels
kind/breaking-change kind/tech-debt
Milestone
1.21

Comments

@fabriziosestito
Copy link
Contributor

Is your feature request related to a problem?

The PolicyServer config should match the format of policies defined in our CRDs.
For this reason, we might want to rename the url field in module.
This also means changing the ConfigMap generation in the controller, by removing the configuration translation logic.

NOTE: This is a breaking change, but it will impact only users using a PolicyServer without the controller, such as raw policy users.

Solution you'd like

No response

Alternatives you've considered

No response

Anything else?

No response
@viccuad viccuad moved this to Todo in Kubewarden Sep 27, 2024
@jvanz jvanz self-assigned this Jan 3, 2025
@jvanz jvanz moved this from Todo to In Progress in Kubewarden Jan 3, 2025
@jvanz jvanz added this to the 1.21 milestone Jan 3, 2025
This was referenced Jan 3, 2025
Merged
Merged
@jvanz jvanz moved this from In Progress to Pending review in Kubewarden Jan 3, 2025
viccuad added a commit to viccuad/docs that referenced this issue Jan 7, 2025
@viccuad
Change url to module for policy-server >= 1.21
29ff844 
See: kubewarden/policy-server#906

Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
@viccuad viccuad mentioned this issue Jan 7, 2025
Merged
@github-project-automation github-project-automation bot moved this from Pending review to Done in Kubewarden Jan 7, 2025
@flavio flavio mentioned this issue Jan 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvanz jvanz

Labels
kind/breaking-change kind/tech-debt
Projects
Kubewarden
Archived in project
Milestone
1.21
3 participants
@flavio @fabriziosestito @jvanz