fix!: renames "url" field into "module". #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1016 +/- ##
=======================================
Coverage 63.58% 63.58%
=======================================
Files 17 17
Lines 1071 1071
=======================================
Hits 681 681
Misses 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvanz
force-pushed
the
rename-url-field
branch
from
cfe621d to
05b1cb0
Compare
viccuad
requested changes
Jan 3, 2025
Renames the "url" field into "module". This makes the field name the same of the name used in the CRDs. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
jvanz
force-pushed
the
rename-url-field
branch
from
05b1cb0 to
6847459
Compare
viccuad
approved these changes
Jan 7, 2025
| @@ -341,7 +341,7 @@ pub enum PolicyOrPolicyGroup { | |||
| #[serde(rename_all = "camelCase")] | |||
| Policy { | |||
| /// The URL where the policy is located | |||
| url: String, | |||
| module: String, | |||
There was a problem hiding this comment.
what about using #[serde(alias = "url")] so we do not break the current behavior?
There was a problem hiding this comment.
Thinking it over, this only affects raw policy users, so I'm fine with the breaking changes.
There was a problem hiding this comment.
Opened kubewarden/docs#484 for updating the user-facing docs.
fabriziosestito
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames the "url" field into "module". This makes the field name the same of the name used in the CRDs.
Fix #906