Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eviction manager): support pod-level rss overuse evict #57

Merged
merged 3 commits into from
May 24, 2023
Merged

feat(eviction manager): support pod-level rss overuse evict #57

merged 3 commits into from
May 24, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented May 9, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

support new policy to evict pods when pod use rss more than user expect.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb added workflow/draft draft: no need to review enhancement New feature or request labels May 9, 2023
@zzzzhhb zzzzhhb changed the title feat(eviction manager): support pod-level rss overuse evict WIP: feat(eviction manager): support pod-level rss overuse evict May 9, 2023
@zzzzhhb zzzzhhb requested review from waynepeking348 and csfldf May 9, 2023 14:00
@zzzzhhb zzzzhhb force-pushed the support_rss_overuse_evict branch 2 times, most recently from 074f86c to 50d906a Compare May 19, 2023 07:55
@zzzzhhb zzzzhhb changed the title WIP: feat(eviction manager): support pod-level rss overuse evict feat(eviction manager): support pod-level rss overuse evict May 19, 2023
@zzzzhhb zzzzhhb added workflow/need-review review: test succeeded, need to review and removed workflow/draft draft: no need to review labels May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 67.02% and project coverage change: +0.59 🎉

Comparison is base (21d86d9) 51.30% compared to head (4b1c1b3) 51.89%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   51.30%   51.89%   +0.59%     
==========================================
  Files         318      334      +16     
  Lines       32418    33541    +1123     
==========================================
+ Hits        16632    17407     +775     
- Misses      13840    14100     +260     
- Partials     1946     2034      +88
Flag Coverage Δ
unittest 51.89% <67.02%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/evictionmanager/endpoint/endpoint.go 0.00% <ø> (ø)
pkg/agent/evictionmanager/manager.go 0.00% <0.00%> (ø)
...m-plugins/cpu/dynamicpolicy/allocation_handlers.go 47.02% <0.00%> (-0.24%) ⬇️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 38.42% <0.00%> (+0.08%) ⬆️
...ourcemanager/fetcher/kubelet/topology/interface.go 0.00% <0.00%> (ø)
pkg/client/control/cnr.go 37.80% <0.00%> (-1.94%) ⬇️
pkg/config/agent/global/base.go 100.00% <ø> (ø)
pkg/config/agent/global/metaserver.go 100.00% <ø> (ø)
pkg/util/general/error.go 0.00% <0.00%> (ø)
...ysadvisor/plugin/qosaware/server/cpu/cpu_server.go 54.26% <3.44%> (-1.40%) ⬇️
... and 45 more

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zzzzhhb zzzzhhb force-pushed the support_rss_overuse_evict branch 2 times, most recently from 827c2ab to 54a2b2c Compare May 19, 2023 08:27
@zzzzhhb zzzzhhb force-pushed the support_rss_overuse_evict branch from 129eda7 to 06569ee Compare May 19, 2023 08:46
waynepeking348
waynepeking348 reviewed May 19, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
pkg/util/qos/mem_enhancement.go Outdated Show resolved Hide resolved
pkg/agent/evictionmanager/plugin/memory/numa_pressure.go Outdated Show resolved Hide resolved
pkg/agent/evictionmanager/plugin/memory/rss_overuse.go Outdated Show resolved Hide resolved
pkg/agent/evictionmanager/plugin/memory/rss_overuse.go Show resolved Hide resolved
pkg/agent/evictionmanager/plugin/memory/helper.go Show resolved Hide resolved
pkg/agent/evictionmanager/plugin/memory/helper.go Outdated Show resolved Hide resolved
waynepeking348
waynepeking348 previously approved these changes May 22, 2023
View reviewed changes
@zzzzhhb zzzzhhb requested a review from waynepeking348 May 22, 2023 12:34
@waynepeking348 waynepeking348 merged commit e6c6e8d into kubewharf:main May 24, 2023
@zzzzhhb zzzzhhb mentioned this pull request Jun 2, 2023
Merged
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
@zzzzhhb @luomingmeng
feat(eviction manager): support pod-level rss overuse evict (kubewhar…
538c760 
…f#57)

* feat: support pod-level rss overuse evict

* refactor: remove duplication

* chore: change api tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynepeking348 waynepeking348 waynepeking348 approved these changes

@csfldf csfldf csfldf approved these changes

Assignees

@zzzzhhb zzzzhhb

Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zzzzhhb @csfldf @waynepeking348