Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eviction): rss overuse eviction base on request #87

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Jun 2, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

this is a modification of pr feat(eviction manager): support pod-level rss overuse evict. The plugin use pod memory request to calculate the threshold instead of pod memory limit.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 52.32% and project coverage change: +1.28 🎉

Comparison is base (21d86d9) 51.30% compared to head (382c21a) 52.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   51.30%   52.58%   +1.28%     
==========================================
  Files         318      348      +30     
  Lines       32418    34263    +1845     
==========================================
+ Hits        16632    18018    +1386     
- Misses      13840    14117     +277     
- Partials     1946     2128     +182     
Flag Coverage Δ
unittest 52.58% <52.32%> (+1.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/evictionmanager/endpoint/endpoint.go 0.00% <ø> (ø)
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 77.01% <ø> (ø)
...gins/cpu/dynamicpolicy/cpueviction/cpu_eviciton.go 0.00% <0.00%> (-63.25%) ⬇️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 40.28% <ø> (+1.94%) ⬆️
...ins/memory/dynamicpolicy/state/state_checkpoint.go 48.05% <0.00%> (ø)
...ourcemanager/fetcher/kubelet/topology/interface.go 0.00% <0.00%> (ø)
.../agent/resourcemanager/reporter/cnr/cnrreporter.go 61.20% <ø> (-3.06%) ⬇️
pkg/agent/resourcemanager/reporter/converter.go 33.33% <ø> (ø)
pkg/agent/resourcemanager/reporter/manager.go 51.37% <ø> (-6.38%) ⬇️
pkg/agent/resourcemanager/reporter/reporter.go 55.55% <ø> (ø)
... and 113 more

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zzzzhhb zzzzhhb added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Jun 2, 2023
@waynepeking348 waynepeking348 merged commit d190e6c into kubewharf:main Jun 4, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants