Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dynamic config for reclaimed_cores overlaping shared_cores #576

Merged
merged 1 commit into from
May 8, 2024

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Features

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 55.80%. Comparing base (29a7b82) to head (0400806).

Files Patch % Lines
...app/options/dynamic/adminqos/advisor/cpu_region.go 60.00% 4 Missing ⚠️
...p/options/dynamic/adminqos/advisor/advisor_base.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   55.77%   55.80%   +0.02%     
==========================================
  Files         532      533       +1     
  Lines       49717    49730      +13     
==========================================
+ Hits        27732    27753      +21     
+ Misses      18450    18435      -15     
- Partials     3535     3542       +7     
Flag Coverage Δ
unittest 55.80% <61.53%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin requested a review from csfldf May 8, 2024 02:01
@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels May 8, 2024
@cheney-lin cheney-lin self-assigned this May 8, 2024
@csfldf csfldf requested a review from luomingmeng May 8, 2024 02:46
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@csfldf csfldf merged commit 4391efa into kubewharf:main May 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants