Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): implement allowing share_cores cpuset overlap with reclaimed_cores #597

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented May 28, 2024

feat(qrm): use state to cache AllowSharedCoresOverlapReclaimedCores

@csfldf csfldf requested a review from cheney-lin May 28, 2024 12:22
@csfldf csfldf self-assigned this May 28, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 60.54422% with 58 lines in your changes missing coverage. Please review.

Project coverage is 56.75%. Comparing base (7e559fd) to head (c18e309).

Files Patch % Lines
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 56.71% 22 Missing and 7 partials ⚠️
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 47.05% 16 Missing and 2 partials ⚠️
...dynamic/adminqos/eviction/cpu_pressure_eviction.go 33.33% 4 Missing ⚠️
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 20.00% 3 Missing and 1 partial ⚠️
...lugins/cpu/dynamicpolicy/state/state_checkpoint.go 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   56.89%   56.75%   -0.15%     
==========================================
  Files         544      544              
  Lines       51682    51807     +125     
==========================================
- Hits        29407    29403       -4     
- Misses      18570    18692     +122     
- Partials     3705     3712       +7     
Flag Coverage Δ
unittest 56.75% <60.54%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csfldf csfldf force-pushed the dev/share_overlap branch 2 times, most recently from 780d19a to e234c99 Compare June 3, 2024 08:58
@csfldf csfldf force-pushed the dev/share_overlap branch 2 times, most recently from 2b5ecd5 to 26f433e Compare June 21, 2024 04:16
@csfldf csfldf force-pushed the dev/share_overlap branch from 26f433e to cccf240 Compare June 28, 2024 06:49
@csfldf csfldf changed the title feat(qrm): use state to cache AllowSharedCoresOverlapReclaimedCores feat(qrm): implement allowing share_cores cpuset overlap with reclaimed_cores Jun 28, 2024
@csfldf csfldf force-pushed the dev/share_overlap branch 4 times, most recently from f2c9b72 to 22824f2 Compare June 29, 2024 06:33
@csfldf csfldf requested review from nightmeng and xu282934741 July 1, 2024 02:54
@csfldf csfldf force-pushed the dev/share_overlap branch 2 times, most recently from c1367b1 to 8025608 Compare July 2, 2024 09:02
@csfldf csfldf force-pushed the dev/share_overlap branch from 8025608 to c18e309 Compare July 2, 2024 16:46
@csfldf csfldf merged commit 194ff6b into kubewharf:main Jul 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants