Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with spd with empty scope #637

Merged

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng marked this pull request as ready for review June 26, 2024 09:28
@luomingmeng luomingmeng force-pushed the dev/fix-spd-indicator-updater branch from 4200dbf to d8cf8dc Compare June 26, 2024 09:32
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.56%. Comparing base (4858a44) to head (d8cf8dc).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   56.75%   56.56%   -0.19%     
==========================================
  Files         545      545              
  Lines       51537    51564      +27     
==========================================
- Hits        29248    29166      -82     
- Misses      18583    18709     +126     
+ Partials     3706     3689      -17     
Flag Coverage Δ
unittest 56.56% <100.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng self-assigned this Jun 27, 2024
@luomingmeng luomingmeng requested a review from xu282934741 June 27, 2024 02:39
@luomingmeng luomingmeng added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Jun 27, 2024
@luomingmeng luomingmeng merged commit 195c5c2 into kubewharf:main Jun 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants