Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the QRM plugin state #702

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Refactor the QRM plugin state by extracting common fields from CPU and memory AllocationInfo into a unified AllocationMeta structure.

Which issue(s) this PR fixes:

Special notes for your reviewer:

…d memory AllocationInfo into a unified AllocationMeta structure.
@luomingmeng luomingmeng force-pushed the dev/refine-qrm-plugin-state branch from 91074c6 to 20ed159 Compare October 7, 2024 14:01
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 71.67756% with 130 lines in your changes missing coverage. Please review.

Project coverage is 56.94%. Comparing base (f6623f4) to head (8f8f24e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/agent/qrm-plugins/commonstate/state.go 64.94% 17 Missing and 17 partials ⚠️
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 65.38% 21 Missing and 6 partials ⚠️
pkg/agent/qrm-plugins/commonstate/util.go 68.29% 11 Missing and 2 partials ⚠️
.../agent/qrm-plugins/cpu/dynamicpolicy/state/util.go 59.25% 8 Missing and 3 partials ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 56.52% 10 Missing ⚠️
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 71.42% 4 Missing and 4 partials ⚠️
...u/dynamicpolicy/validator/validator_cpu_advisor.go 53.84% 1 Missing and 5 partials ⚠️
pkg/agent/qrm-plugins/commonstate/pool.go 85.71% 3 Missing and 1 partial ⚠️
...qrm-plugins/cpu/dynamicpolicy/cpuadvisor/helper.go 66.66% 2 Missing and 1 partial ⚠️
...-plugins/cpu/dynamicpolicy/policy_async_handler.go 0.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   57.14%   56.94%   -0.21%     
==========================================
  Files         568      570       +2     
  Lines       54981    54864     -117     
==========================================
- Hits        31419    31240     -179     
- Misses      19625    19694      +69     
+ Partials     3937     3930       -7     
Flag Coverage Δ
unittest 56.94% <71.67%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nightmeng
nightmeng previously approved these changes Oct 8, 2024
@luomingmeng luomingmeng force-pushed the dev/refine-qrm-plugin-state branch from 25709d2 to 8f8f24e Compare October 9, 2024 12:29
@luomingmeng luomingmeng requested a review from csfldf October 10, 2024 03:34
@luomingmeng luomingmeng merged commit 56ba904 into kubewharf:main Oct 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants