Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and enhance QRM plugins support for reclaim_cores with numa_binding #741

Merged

Conversation

luomingmeng
Copy link
Collaborator

@luomingmeng luomingmeng commented Dec 12, 2024

What type of PR is this?

Enhancements

What this PR does / why we need it:

This MR introduces the following main changes to support reclaim_cores with numa_binding:

  • Extract common fields from AllocationInfo into metadata and util Refactor the QRM plugin state #702
  • Update plugin state via LW interface
  • Adapt CPU plugin for RNB admission and provision
  • Adapt memory plugin for RNB admission and provision
  • Support CPU suppression and eviction for RNB
  • Support CPU idle for RNB
  • Update CPU plugin for pod NUMA annotations
  • Enable CPU plugin to set cgroup path via Allocate Response annotations

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng changed the title support reclaimed cores numa binding qrm plugins support reclaimed cores numa binding Dec 12, 2024
@luomingmeng luomingmeng changed the title qrm plugins support reclaimed cores numa binding Refactor and enhance QRM plugins support for reclaim_cores with numa_binding Dec 12, 2024
@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-cores-numa-binding branch from 601e19a to 5e7754d Compare December 12, 2024 09:09
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 58.78159% with 636 lines in your changes missing coverage. Please review.

Project coverage is 56.40%. Comparing base (c1ff5df) to head (f034ca0).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
...memory/dynamicpolicy/policy_allocation_handlers.go 50.81% 75 Missing and 16 partials ⚠️
...ugins/memory/dynamicpolicy/policy_hint_handlers.go 64.15% 63 Missing and 13 partials ⚠️
...qrm-plugins/cpu/dynamicpolicy/cpuadvisor/cpu.pb.go 3.94% 70 Missing and 3 partials ⚠️
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 55.46% 42 Missing and 15 partials ⚠️
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 60.28% 43 Missing and 13 partials ⚠️
...olicy/cpueviction/strategy/pressure_suppression.go 52.00% 31 Missing and 5 partials ⚠️
...-plugins/cpu/dynamicpolicy/policy_hint_handlers.go 82.16% 25 Missing and 8 partials ⚠️
...in/qosaware/resource/memory/plugin/memory_guard.go 59.74% 30 Missing and 1 partial ⚠️
...nt/qrm-plugins/memory/dynamicpolicy/state/state.go 45.45% 27 Missing and 3 partials ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 50.00% 17 Missing and 3 partials ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
+ Coverage   56.15%   56.40%   +0.25%     
==========================================
  Files         597      599       +2     
  Lines       68027    69264    +1237     
==========================================
+ Hits        38198    39068     +870     
- Misses      25798    26074     +276     
- Partials     4031     4122      +91     
Flag Coverage Δ
unittest 56.40% <58.78%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-cores-numa-binding branch 2 times, most recently from 69f9e86 to bcd905c Compare December 12, 2024 12:30
@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-cores-numa-binding branch from bcd905c to 1f1df86 Compare December 16, 2024 12:30
@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-cores-numa-binding branch 3 times, most recently from 1477bcb to 22235f1 Compare December 16, 2024 13:51
@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-cores-numa-binding branch from 22235f1 to f034ca0 Compare December 16, 2024 13:51
@xu282934741 xu282934741 merged commit b586da2 into kubewharf:main Dec 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants