Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): Remove the constraints on move pages #729

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin self-assigned this Nov 28, 2024
@cheney-lin cheney-lin added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.94%. Comparing base (19aa317) to head (5cd636d).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   56.04%   55.94%   -0.10%     
==========================================
  Files         594      597       +3     
  Lines       67830    67955     +125     
==========================================
+ Hits        38012    38020       +8     
- Misses      25771    25905     +134     
+ Partials     4047     4030      -17     
Flag Coverage Δ
unittest 55.94% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yadzhang
Copy link
Collaborator

LGTM

@xu282934741 xu282934741 merged commit 76e6c12 into kubewharf:main Nov 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants