Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): Remove the constraints on move pages #729

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix(*): Remove the constraints on move pages #729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions pkg/agent/qrm-plugins/memory/dynamicpolicy/util_linux_amd64.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ const (

// MovePagesAcceptableTimeCost is acceptable time cost of each move pages is 20ms
MovePagesAcceptableTimeCost = 20
MBytes = 1024 * 1024

// MinRSSSkipMigrate is min rss size to skip migrate the process numa pages.
MinRSSSkipMigrate = 10 * MBytes

SystemNodeDir = "/sys/devices/system/node/"
ProcDir = "/proc"
Expand Down Expand Up @@ -252,11 +248,6 @@ func MovePagesForProcess(ctx context.Context, procDir string, pid int, srcNumas
return err
}

// skip process whose rss is below threshold.
if pidSmapsInfo.totalRss < MinRSSSkipMigrate {
return nil
}

srcNumasBitSet, err := bitmask.NewBitMask(srcNumas...)
if err != nil {
return fmt.Errorf("failed to NewBitMask allowd numas %+v", srcNumas)
Expand Down