chore: add clipboard debug #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johncowen
force-pushed
the
chore/clipboard-debug
branch
from
bc8608d
to
1a2555a
Compare
johncowen
force-pushed
the
chore/clipboard-debug
branch
from
1a2555a
to
0b3d819
Compare
kleinfreund
approved these changes
Jan 10, 2024
johncowen
added a commit
that referenced
this pull request
Jan 15, 2024
…2006) I noticed we were getting warnings for re-registering a component due to #1981 This happens both in browser development environments (PR previews and locally) and also CLI based unit tests. The unit test ones are noisier than the browser ones, seeing as the browser ones need to be looked for. This PR only does the re-registration if we don't have a `process` meaning it doesn't happen in anything CLI based. Signed-off-by: John Cowen <john.cowen@konghq.com>
This was referenced Apr 29, 2024
Merged
johncowen
added a commit
that referenced
this pull request
May 21, 2024
We have some places where we need eXtra eXtensions on top of KCopy This adds a thin wrapper over KCopy and builds things out so we can use XCopyButton (née KCopy) everywhere without it being problematic. I've kept `TextWithCopyButton` at least temporarily but it now just wraps over `XCopyButton`. We use `TextWithCopyButton ` quite a lot so I haven't gone through and search/replaced all the usages, I may do that here and then also `TextWithCopyButton` so we only have one copy button thing. I also added back in our clipboard debugging tooling that I originally added in #1981 and was removed in #2374 Last, I originally called this `XCopy` (like `KCopy`), but then realized this problem was probably caused by this naming (no explicit `*Button`) so I called it `XCopyButton` to make it clear this is a button and doesn't need to be/shouldn't be wrapped in another button Closes #2513 Related: #2517 (<== I thought this was a fix but it wasn't) Signed-off-by: John Cowen <john.cowen@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dev only console logger for clipboard copying by decorating
KClipboardProvider::copyToClipboardvia ourdevelopment.tsservice container config.Also added a single K8s property to relevant mocks (I figured this was enough to be able to tell if you'd copying the k8s format or not without having to be super realistic with the K8s formatted mock)
All in all this PR helps testing/debugging our copy buttons
Totally non-urgent, I did this while I was trying and figure out what was going on with #1967 and thought I may as well PR it.