chore: add XCopyButton component #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
Signed-off-by: John Cowen <john.cowen@konghq.com>
lahabana
approved these changes
May 21, 2024
johncowen
added a commit
that referenced
this pull request
May 22, 2024
A while back we decided we wanted a split linting environment (#1179) which we did alongside other improvements in #2545. Since then we've decided to stick to one single linting environment, i.e. the stricter one. But we still only want to apply fixes on pre-commit and not in CI (CI should fail not fix). --- I also noticed that: - We needed `console.info` (you can see usage in #2531), so aswell as adding that I changed the `console.log`s we used in a cypress config to use `console.info` instead. - `npm install` was being passed `--frozen-lockfile` which is a `yarn` argument, it should be `npm clean-install` Signed-off-by: John Cowen <john.cowen@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some places where we need eXtra eXtensions on top of KCopy
This adds a thin wrapper over KCopy and builds things out so we can use XCopyButton (née KCopy) everywhere without it being problematic.
I've kept
TextWithCopyButtonat least temporarily but it now just wraps overXCopyButton. We useTextWithCopyButtonquite a lot so I haven't gone through and search/replaced all the usages, I may do that here and then alsoTextWithCopyButtonso we only have one copy button thing.I also added back in our clipboard debugging tooling that I originally added in #1981 and was removed in #2374
Last, I originally called this
XCopy(likeKCopy), but then realized this problem was probably caused by this naming (no explicit*Button) so I called itXCopyButtonto make it clear this is a button and doesn't need to be/shouldn't be wrapped in another buttonCloses #2513
Related: #2517 (<== I thought this was a fix but it wasn't)