Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some places where we need eXtra eXtensions on top of KCopy
This adds a thin wrapper over KCopy and builds things out so we can use XCopyButton (née KCopy) everywhere without it being problematic.
I've kept
TextWithCopyButton
at least temporarily but it now just wraps overXCopyButton
. We useTextWithCopyButton
quite a lot so I haven't gone through and search/replaced all the usages, I may do that here and then alsoTextWithCopyButton
so we only have one copy button thing.I also added back in our clipboard debugging tooling that I originally added in #1981 and was removed in #2374
Last, I originally called this
XCopy
(likeKCopy
), but then realized this problem was probably caused by this naming (no explicit*Button
) so I called itXCopyButton
to make it clear this is a button and doesn't need to be/shouldn't be wrapped in another buttonCloses #2513
Related: #2517 (<== I thought this was a fix but it wasn't)