fix(MeshHTTPRoute): weight should be a minimum of 0 (#5653)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
kumahq · Jan 11, 2023 · 25f2275 · 25f2275
1 parent 429fa77
commit 25f2275
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/pkg/plugins/policies/meshhttproute/api/v1alpha1/meshhttproute.go b/pkg/plugins/policies/meshhttproute/api/v1alpha1/meshhttproute.go
@@ -58,5 +58,6 @@ type Filter struct {
 
 type BackendRef struct {
 	common_api.TargetRef `json:",omitempty"`
-	Weight               int `json:"weight,omitempty"`
+	// +kubebuilder:validation:Minimum=0
+	Weight uint `json:"weight,omitempty"`
 }
diff --git a/pkg/plugins/policies/meshhttproute/api/v1alpha1/schema.yaml b/pkg/plugins/policies/meshhttproute/api/v1alpha1/schema.yaml
@@ -73,6 +73,7 @@ properties:
                               description: Tags used to select a subset of proxies by tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
                               type: object
                             weight:
+                              minimum: 0
                               type: integer
                           type: object
                         type: array

diff --git a/pkg/plugins/policies/meshhttproute/k8s/crd/kuma.io_meshhttproutes.yaml b/pkg/plugins/policies/meshhttproute/k8s/crd/kuma.io_meshhttproutes.yaml
@@ -108,6 +108,7 @@ spec:
                                         `MeshSubset` and `MeshServiceSubset`
                                       type: object
                                     weight:
+                                      minimum: 0
                                       type: integer
                                   type: object
                                 type: array