Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MeshHTTPRoute): weight should be a minimum of 0 #5653

Merged
merged 1 commit into from
Jan 11, 2023
Merged

fix(MeshHTTPRoute): weight should be a minimum of 0 #5653

merged 1 commit into from
Jan 11, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jan 11, 2023 •
edited by lahabana
Loading

Spotted by @slonka in #5625

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(policy): implement MeshHTTPRoute policy

@michaelbeaumont
fix(MeshHTTPRoute): weight should be a minimum of 0
52b906f 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested review from slonka, a team and lukidzi and removed request for a team January 11, 2023 13:48
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) January 11, 2023 13:50
@michaelbeaumont michaelbeaumont merged commit 25f2275 into kumahq:master Jan 11, 2023
@michaelbeaumont michaelbeaumont deleted the fix/route_weight branch January 11, 2023 15:01
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jan 14, 2023
@michaelbeaumont @bartsmykla
fix(MeshHTTPRoute): weight should be a minimum of 0 (kumahq#5653)
5b8f364 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@lukidzi lukidzi lukidzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelbeaumont @slonka @lukidzi