Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new rpc snooper from ethpandaops/rpc-snooper #567

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

pk910
Copy link
Member

@pk910 pk910 commented Apr 16, 2024

This PR replaces the existing RPC snooper with a new one.

The existing snooper unfortunately causes several problems when intercepting CL<>VC connections.
This is due to lack of proper support for the event stream calls.
These event stream calls are currently timing out after roughly a minute and do not serve any events.

The new snooper properly handles event stream calls and adds the invoked events to the log output.
Besides of that it supports all the common snooper functionality.
It logs prettified JSON and hex encoded SSZ bodies as usual.

@pk910 pk910 marked this pull request as draft April 16, 2024 21:32
@pk910
Copy link
Member Author

pk910 commented Apr 16, 2024

Test with all CL<>VC pairs shows same result as without snooper:
https://github.com/ethpandaops/assertoor-test/actions/runs/8712937458

Test with all EL<>CL fully works:
https://github.com/ethpandaops/assertoor-test/actions/runs/8713231136

both workflow runs were executed with this branch.

@pk910 pk910 marked this pull request as ready for review April 17, 2024 14:01
@pk910 pk910 merged commit 5676f0d into main Apr 17, 2024
18 checks passed
@pk910 pk910 deleted the pk910/go-rpc-snooper branch April 17, 2024 14:01
barnabasbusa pushed a commit that referenced this pull request Apr 19, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.2.0](2.1.0...2.2.0)
(2024-04-19)


### Features

* add assertoor test for per PR CI job
([#537](#537))
([8ef5c57](8ef5c57))
* add blutgang rpc load balancer
([#569](#569))
([1be5f95](1be5f95))
* add dugtrio beacon load balancer
([#568](#568))
([56d2fa3](56d2fa3))
* add new assertoor test to per ci jobs
([#545](#545))
([3005d46](3005d46))
* use new rpc snooper from `ethpandaops/rpc-snooper`
([#567](#567))
([5676f0d](5676f0d))


### Bug Fixes

* add --contract-deployment-block parameter for Prysm
([#557](#557))
([d8dfbae](d8dfbae))
* Added '--enable-private-discovery' to Grandine
([#541](#541))
([a1ae708](a1ae708))
* beaconchain explorer
([#531](#531))
([b62ed6f](b62ed6f))
* beaconchain explorer
([#538](#538))
([ce1f337](ce1f337))
* blobber incorrect url
([#528](#528))
([6f84e3d](6f84e3d))
* bump json rpc snooper
([#553](#553))
([f69c4a7](f69c4a7))
* disable full sync if gcmode is archive
([#563](#563))
([b7592ec](b7592ec))
* disable pbss when gcmode archive set
([#559](#559))
([e085462](e085462))
* disable pbss when gcmode archive set, force hash based init
([#562](#562))
([3e1c7a6](3e1c7a6))
* disable static peers
([#529](#529))
([c5d4028](c5d4028))
* enable single node mode on lodestar by default
([#558](#558))
([555ad7d](555ad7d))
* fix doc string typo
([#560](#560))
([13de3f6](13de3f6))
* fix failing persistence test
([#554](#554))
([99242d6](99242d6))
* increase mem limit of snooper
([#546](#546))
([6ba5770](6ba5770))
* prysm beacon http url
([#536](#536))
([4914531](4914531))
* prysm beacon_http_url
([#535](#535))
([ee7528c](ee7528c))
* prysm vc
([#533](#533))
([72ddeb2](72ddeb2))
* remove un-needed prysm vc check
([#542](#542))
([f6326fe](f6326fe))
* set application protocol to be http for rpc
([#548](#548))
([905de7c](905de7c))
* set the correct default vc image
([#544](#544))
([953741d](953741d))
* uniformize keymanager
([#534](#534))
([a6a2830](a6a2830))
* update prometheus api
([#539](#539))
([d2b9fb8](d2b9fb8))
* update vc &lt;&gt; cl matrix
([#564](#564))
([0ffcf74](0ffcf74))
* update vc compatibility matrix
([#543](#543))
([58c4684](58c4684))
* use `minimal-preset` images for dora & assertoor when minimal preset
is used
([#532](#532))
([ad7773e](ad7773e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants