Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: build script should check for the presence of expected node and go version #239

Closed
eliziario opened this issue Mar 16, 2023 · 1 comment
Closed

[FR]: build script should check for the presence of expected node and go version #239

eliziario opened this issue Mar 16, 2023 · 1 comment
Assignees
@victorcolombo
Labels
feature request

Comments

@eliziario
Copy link
Contributor

Background & current behavior

As I tried to build the project for the first time, yarn install failed because I was using an incompatible version of node

Desired behavior

It would be interesting if scripts/build.sh checked for specific versions of node and go.

How important is this feature or improvement to you?

Nice to have, this feature would make using Kurtosis more enjoyable.
@eliziario eliziario mentioned this issue Mar 16, 2023
Merged
2 tasks
victorcolombo added a commit that referenced this issue Mar 22, 2023
@eliziario @victorcolombo
feat: build script check for go and node versions (#240)
4749dbe 
## Description:
Makes scripts/build.sh checked for specific go and node versions instead
of letting build fail later with obscure error during for example, yarn
install.

## Is this change user facing?
<!-- A user facing change is one that you should expect a day-to-day
user to encounter or if the change requires user-action upon or before
upgrading. If in doubt, select "Yes" -->
* [ ] Yes
* [X] No

<!-- If yes, please add the `user facing` label to this Pull Request -->

## References (if applicable):
[ISSUE: 239](#239)

---------

Co-authored-by: Victor Colombo <victorcolombo@users.noreply.github.com>
@h4ck3rk3y
Copy link
Contributor

Thanks @eliziario for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victorcolombo victorcolombo

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eliziario @victorcolombo @h4ck3rk3y