-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR]: build script should check for the presence of expected node and go version #239
Labels
Comments
2 tasks
victorcolombo
added a commit
that referenced
this issue
Mar 22, 2023
## Description: Makes scripts/build.sh checked for specific go and node versions instead of letting build fail later with obscure error during for example, yarn install. ## Is this change user facing? <!-- A user facing change is one that you should expect a day-to-day user to encounter or if the change requires user-action upon or before upgrading. If in doubt, select "Yes" --> * [ ] Yes * [X] No <!-- If yes, please add the `user facing` label to this Pull Request --> ## References (if applicable): [ISSUE: 239](#239) --------- Co-authored-by: Victor Colombo <victorcolombo@users.noreply.github.com>
Thanks @eliziario for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background & current behavior
As I tried to build the project for the first time, yarn install failed because I was using an incompatible version of node
Desired behavior
It would be interesting if scripts/build.sh checked for specific versions of node and go.
How important is this feature or improvement to you?
Nice to have, this feature would make using Kurtosis more enjoyable.
The text was updated successfully, but these errors were encountered: