-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build script check for go and node versions #240
feat: build script check for go and node versions #240
Conversation
@kurtosis-tech/engineers It looks like circle ci is refusing to run the pipeline on my PR :-) |
Hey @eliziario , thanks for submitting this and congratulations on being our first external contributor!!! @victorcolombo is going to review shortly. Also, if I'm correctly interpreting your name and you're Brazilian - bem-vindo ao Kurtosis! @victorcolombo é brasileiro, e @galenmarchetti e eu somos americanos apaixonados pelo Brasil e morando aqui :) |
Thanks @mieubrisse! Yes, I am a brazilian and carioca. Tudo beleza ai @victorcolombo and @galenmarchetti? :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @eliziario ! Thanks for the first contribution on this repo 😃
Great job on the instructions to install the correct node version, this will help a lot of folks trying to build Kurtosis from scratch.
I left one comment, once that is addressed we are good to merge!
Additionally I see there is some CI weirdness going on (we might have a misconfigured permissions), I'm working on it right now to address it |
4f554e8
to
d8cd856
Compare
…d, but ensure only minimal Go version
d8cd856
to
67733a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @eliziario! I went ahead and approved it, will work on merging this and will let you know once this is released 🚀
🤖 I have created a release *beep* *boop* --- ## [0.69.2](0.69.1...0.69.2) (2023-03-22) ### Features * Add context `add` command ([#278](#278)) ([bd56cae](bd56cae)) * build script check for go and node versions ([#240](#240)) ([4749dbe](4749dbe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@eliziario Sua mudança já tá no release |
@eliziario congrats on being the first external contribution to Kurtosis!! I'd love to learn more about what you're thinking of using Kurtosis for; would you be down to schedule a chat with me? You can do so with |
Description:
Makes scripts/build.sh checked for specific go and node versions instead of letting build fail later with obscure error during for example, yarn install.
Is this change user facing?
References (if applicable):
ISSUE: 239