GA内の定数をConfigに移動 #377
Merged
GA内の定数をConfigに移動 #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanimon
requested changes
Oct 31, 2018
There was a problem hiding this comment.
概ね OK です．
細かい修正を2箇所お願いします．
加えて，README とコンフィグファイルのサンプルの更新もお願いします．
|
@a-tanikd 修正しました、ご確認よろしくお願いします。 |
|
@a-tanikd 修正しました、ご確認よろしくお願いします！ |
Closed
Merged
Closed
tanimon
added a commit
that referenced
this pull request
Dec 11, 2018
In order to follow the changing meaning of these values on #377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #343
内容