Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User needs to write full mail list name to access its details #25

Closed
th-duvanel opened this issue Aug 14, 2024 · 0 comments
Closed

User needs to write full mail list name to access its details #25

th-duvanel opened this issue Aug 14, 2024 · 0 comments
Labels
bug Something isn't working properly waiting-stable Waiting merging into the master branch

Comments

@th-duvanel
Copy link
Contributor

th-duvanel commented Aug 14, 2024 •
edited
Loading

Description:

For access the list details, it is necessary to write its full name or press TAB, and, after this, press ENTER to access its details. Without its full name, its not possible.

How to reproduce:

Just try to press ENTER in any patch without writing anything in the search bar, you can't access it.

Expected behavior:

User should be able to access without writing the patch full name.
@th-duvanel th-duvanel added the bug Something isn't working properly label Aug 14, 2024
@th-duvanel th-duvanel changed the title Accessing the patch details needs to write its full name User needs to write full patch name to access its details Aug 14, 2024
th-duvanel added a commit to th-duvanel/patch-hub that referenced this issue Aug 14, 2024
@th-duvanel
src: app: fix: removed obligation to write the full list name
4a7ca85 
Removed the obligation to write the full mail list name when accessing
its details.
Besides that, a possible problem generated by that fix is also solved:
selecting in a null list would cause a panic, now it is handled by a
check.

Closes kworkflow#25

Signed-off-by: Thiago Duvanel <thiago.duvanel@usp.br>
Signed-off-by: David Tadokoro <davidbtadokoro@usp.br>
@th-duvanel th-duvanel mentioned this issue Aug 14, 2024
Closed
@th-duvanel th-duvanel changed the title User needs to write full patch name to access its details User needs to write full mail list name to access its details Aug 14, 2024
davidbtadokoro pushed a commit that referenced this issue Aug 15, 2024
@th-duvanel @davidbtadokoro
src: app: fix: removed obligation to write the full list name
6b06213 
Removed the obligation to write the full mail list name when accessing
its details.

Besides that, a possible problem generated by that fix is also solved:
selecting in a null list would cause a panic, now it is handled by a
check.

Closes: #25

[Maintainer edits]
- Remove deprecated TAB completion from `main.rs` and
  `set_target_list_with_highlighted_list()` function
- Remove comments from `has_valid_target_list()`
- Adapt comments from `init_latest_patchsets_state()`

Signed-off-by: Thiago Duvanel <thiago.duvanel@usp.br>
Reviewed-by: David Tadokoro <davidbtadokoro@usp.br>
Signed-off-by: David Tadokoro <davidbtadokoro@usp.br>
@davidbtadokoro davidbtadokoro added waiting-stable Waiting merging into the master branch good-first-issue Simple change for newcomers and removed good-first-issue Simple change for newcomers labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working properly waiting-stable Waiting merging into the master branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidbtadokoro @th-duvanel