src: app: fix: removed obligation to write the full list name #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the obligation to write the full mail list name when accessing its details. Besides that, a possible problem generated by that fix is also solved: selecting in a null list would cause a panic, now it is handled by a check. Closes kworkflow#25 Signed-off-by: Thiago Duvanel <thiago.duvanel@usp.br> Signed-off-by: David Tadokoro <davidbtadokoro@usp.br>
|
Hi @th-duvanel and thanks for your first contribution! Merged into the unstable branch 👍 I tested the change, and it works as intended. The previous behavior was indeed bad UX on my part 😬 I've made some quality adjustments, which you can see in the merged commit message in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the obligation to write the full mail list name when accessing its details.
Besides that, a possible problem generated by that fix is also solved: selecting in a null list would cause a panic, now it is handled by a check.
Closes #25