Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for first release of the Compass Manager #57

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Update dependencies for first release of the Compass Manager #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b10b2c
Prepare dependencies for release
mvshao Dec 1, 2023
45d3718
go sum cleanup
mvshao Dec 1, 2023
2fb962a
Bump golangci GitHub action
mvshao Dec 1, 2023
267df43
Add nolint to dot imports in tests
mvshao Dec 1, 2023
2bef69b
Gci-ed file
mvshao Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/golangci-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: '1.20'
go-version: '1.21'
cache: false
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
# Require: The version of golangci-lint to use.
# When `install-mode` is `binary` (default) the value can be v1.2 or v1.2.3 or `latest` to use the latest version.
# When `install-mode` is `goinstall` the value can be v1.2.3, `latest`, or the hash of a commit.
version: v1.54.2
version: v1.55.2

# Optional: working directory, useful for monorepos
# working-directory: somedir
Expand Down
4 changes: 2 additions & 2 deletions controllers/compassmanager_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (

"github.com/kyma-project/compass-manager/api/v1beta1"
kyma "github.com/kyma-project/lifecycle-manager/api/v1beta2"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
. "github.com/onsi/ginkgo/v2" //nolint:revive
Copy link
Member

@Disper Disper Dec 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what could be wrong with this line. Could you elaborate why linter check was failing here and it had to be ignored?

Copy link
Contributor Author

@mvshao mvshao Dec 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was failing because dot import. In most cases (e.g main files) that is bad practice to use this kind of import. But in Go test, if the programmer knows how dot imports work that could be allowed.
In our case, we can remove . and replace it with any name we want. But after that, we need to add that name before any function call exported from that package (e.g Describe(), It(), By(), Expect() ). Such a way will make the main loops of the program less readable and transparent. So that is why I chose that approach.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Sounds reasonable to me.

. "github.com/onsi/gomega" //nolint:revive
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand Down
4 changes: 2 additions & 2 deletions controllers/suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (
"github.com/kyma-project/compass-manager/api/v1beta1"
"github.com/kyma-project/compass-manager/controllers/mocks"
kyma "github.com/kyma-project/lifecycle-manager/api/v1beta2"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
. "github.com/onsi/ginkgo/v2" //nolint:revive
. "github.com/onsi/gomega" //nolint:revive
"github.com/sirupsen/logrus"
"k8s.io/client-go/kubernetes/scheme"
"k8s.io/client-go/rest"
Expand Down
Loading