Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an ApplicationSource CloudEvents 1.0 http adapter #6159

Closed
2 tasks done
devguyio opened this issue Oct 29, 2019 · 4 comments
Closed
2 tasks done

Implement an ApplicationSource CloudEvents 1.0 http adapter #6159

devguyio opened this issue Oct 29, 2019 · 4 comments
Assignees
Labels
area/documentation Issues or PRs related to documentation area/eventing Issues or PRs related to eventing

Comments

@devguyio
Copy link
Contributor

devguyio commented Oct 29, 2019

Description

We need to create the adapter which will be deployed by the ApplicationSource controller. This adapter does the following :

  1. It is configured with the correct Event Source in order to enrich the events.
  2. It receives CloudEvents 1.0 events and sends it to its companion Channel.

knative_brokers_co_exist_arch

Breakdown
Work left starting 11.11.2019

  • Updating EventSource controller for integration with the adapter.
  • Documentation

AC

  1. There is an ApplicationSource adapter which gets created by the ApplicationSource controller.
  2. The ApplicationSource adapter behaves as described above.
  3. Documentations are updated.
@devguyio devguyio added this to the Sprint_Skydiving_Tunas_5 milestone Oct 29, 2019
@devguyio devguyio added the area/eventing Issues or PRs related to eventing label Oct 29, 2019
@nachtmaar nachtmaar self-assigned this Oct 30, 2019
@antoineco
Copy link
Contributor

antoineco commented Nov 5, 2019

The following fields should be added to the HTTPSource spec as part of this implementation.

type HTTPSourceSpec struct {
    Source string
    // SourceID string (renamed)
    // optional
    MaxRequestSize int
}

@k15r
Copy link
Contributor

k15r commented Nov 5, 2019

SourceID should be renamed to Source as this is also the name of the field in the cloudevents specification.
Also it would be nice it we could limit the string to be a valid URI (same type as required by cloudevents spec)

@nachtmaar
Copy link
Contributor

nachtmaar commented Nov 7, 2019

Open question: Do we expect that there is always a eventtypeversion set in the cloudevent? It might be required by the trigger to filter events based on eventtypeversion. eventype is required by the spec, eventtypeversion however is an optional extension.
The current implementation with event-service ensures that the eventtypeversion exists.

The combination of eventtypeversion and eventype is used in the UI to filter on events, e.g. v1.order_created vs v2.order_created.

If we want to rely on eventtypeversion for the lambda trigger, then we should validate it inside the adapter.

As discussed with @Abd4llA, will be done in a separate ticket: #6271

@devguyio devguyio modified the milestones: Sprint_Skydiving_Tunas_5, Sprint_SkydivingTunas_6 Nov 11, 2019
@devguyio devguyio added the area/documentation Issues or PRs related to documentation label Nov 11, 2019
@nachtmaar
Copy link
Contributor

nachtmaar commented Nov 13, 2019

As discussed with @Abd4llA and @bszwarc, developer document is delivered. Existing documentation (how eventing in kyma works) will be done in a separate ticket, since it is part of the whole broker/trigger epic.

---> #6312 documentation ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation area/eventing Issues or PRs related to eventing
Projects
None yet
Development

No branches or pull requests

4 participants