Knative Source HTTP Adapter for Broker/Trigger #6236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Author: Marco Bebway <marco.bebway@sap.com>
fixed typo
Kyma ships only with that version.
We know this is ugly, but there is currently no other way see knative/eventing#2052
…-applicationsource-ce-1-0-http-adapter
…source-ce-1-0-http-adapter' into 6159-implement-an-applicationsource-ce-1-0-http-adapter
- Move main_test from main package to adapter package since sharedmain is cmd is not directly tested anymore - Add encoding to tabletest - Check error code and error response
nachtmaar
requested review from
klaudiagrz,
lilitgh,
majakurcius,
marcobebway,
mmitoraj and
montaro
as code owners
nachtmaar
requested review from
rakesh-garimella,
sayanh and
tomekpapiernik
as code owners
nachtmaar
changed the title
antoineco
reviewed
Nov 11, 2019
antoineco
approved these changes
Nov 12, 2019
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
montaro
suggested changes
Nov 13, 2019
Co-Authored-By: Ahmed ElRefaey Hamouda <ahmed.rifaey@gmail.com>
montaro
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
/healthzCredits also go to @k15r
Related issue(s)
#6159
Due to an open issue in knative/eventing#2052, we need to patch vendor :/