Integrate HTTP adapter with Reconciler #6272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoineco
requested review from
abbi-gaurav,
devguyio,
alexandra-simeonova,
anishj0shi,
bszwarc,
joek,
k15r,
kazydek,
klaudiagrz,
lilitgh,
majakurcius,
marcobebway,
mmitoraj,
montaro and
nachtmaar
as code owners
antoineco
requested review from
rakesh-garimella,
sayanh and
tomekpapiernik
as code owners
nachtmaar
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
Integration looks good to me:
- logger and metrics are correctly initialized in adapter, I could get the metrics from the adapter
- As discussed: the
EVENT_SOURCEvariable has to be set in the adapter and it should come from the CR object - Even though the readiness probe does not work, I am ok with merging the PR since we have the 503 bug open where we can investigate
* Wait for Channel readiness before synchronizing adapter Service * Add Ports and EnvVars to adapter Service * Pass metrics and logging configs to adapter Service * Configiure ReadinessProbe of adapter Service * Inject adapter image via envconfig instead of os.Getenv() * Refactor some of the reconciliation flow
|
🥰 Documentation preview ready! 🥰 Built with commit fd79e90 https://deploy-preview-6272--kyma-project-docs-preview.netlify.com |
k15r
reviewed
Nov 14, 2019
k15r
reviewed
Nov 14, 2019
k15r
approved these changes
Nov 14, 2019
bszwarc
approved these changes
Nov 15, 2019
This was referenced Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate HTTP adapter with Reconciler. Round 2 of #6236
Changes proposed in this pull request:
Related issue(s)
#6236
#6175