-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Knative event sources component #6175
Conversation
🥰 Documentation preview ready! 🥰 Built with commit 274e251 https://deploy-preview-6175--kyma-project-docs-preview.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Controller looks really good to me 👍
{ | ||
Name: "Invalid object key", | ||
Key: tNs + "/" + tName + "/invalid", | ||
WantErr: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we able to specify which errors to expect in such case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not, we would have to open a PR to add that feature to Knative's table tests: https://godoc.org/knative.dev/pkg/reconciler/testing#TableRow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add CODEOWNERS for this component. Question, can this component be outside kyma mono repo? (Is it kyma specific?)
@piotrmsc IMHO this should stay in Kyma as |
@piotrmsc done, thanks for pointing that out. |
Ok, in such case it should stay in kyma. |
} | ||
|
||
// makeKnService returns the desired Knative Service object for a given | ||
// HTTPSource. An optional Knative Service can be passed as parameter, in which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comment should somehow reflect that only 0 or 1 knative services can be passed in the variadic currrentKsvc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it clear from the phrase "An optional Knative Service can be passed as parameter"? It's singular, and there is the word optional. For an internal method that will do IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of non essential questions, but it lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments.
Includes HTTPSource type and corresponding controller. Co-Author: Marco Bebway <marco.bebway@sap.com> Co-Author: Ahmed Hamouda <a.hamouda@sap.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Description
Changes proposed in this pull request:
HTTPSource
only for the time being)Related issue(s)
#6033 (Preparation work)
#6150