fix: Split resource deletion #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
ruanxin
force-pushed
the
blocking-deletion-mode
branch
from
1bfb5c5 to
631dfc5
Compare
kyma-bot
added
the
do-not-merge/work-in-progress
kyma-bot
removed
the
do-not-merge/work-in-progress
…cking-deletion-mode
ruanxin
commented
Mar 4, 2024
kyma-bot
added
size/XXL
ruanxin
commented
Mar 4, 2024
ruanxin
force-pushed
the
blocking-deletion-mode
branch
from
3b33d9f to
1ba56fe
Compare
lindnerby
requested changes
Mar 7, 2024
There was a problem hiding this comment.
This is a good opportunity to increase unit test coverage.
There is no internal/pkg/resources/cleanup_test.go. Let's add these and also lock this pkg in unit-test-coverage.yaml!
May be a bit of work and refactoring needed, and also concurrency involved internally, so not super trivial, but we agreed to increase the coverage.
tests/moduletemplates/moduletemplate_template_operator_v1_regular.yaml
Outdated
Show resolved
Hide resolved
ruanxin
force-pushed
the
blocking-deletion-mode
branch
2 times, most recently
from
9f908f3 to
458bbef
Compare
enhance e2e to test module deletion when managed CR get blocked
ruanxin
force-pushed
the
blocking-deletion-mode
branch
from
458bbef to
60aff34
Compare
# Conflicts: # tests/e2e/utils_test.go
ruanxin
force-pushed
the
blocking-deletion-mode
branch
from
310ad2f to
01de87c
Compare
ruanxin
force-pushed
the
blocking-deletion-mode
branch
from
084ea36 to
6f572d3
Compare
ruanxin
force-pushed
the
blocking-deletion-mode
branch
from
520c8a8 to
fe9502a
Compare
ruanxin
force-pushed
the
blocking-deletion-mode
branch
from
1f19806 to
34ef28c
Compare
ruanxin
force-pushed
the
blocking-deletion-mode
branch
from
34ef28c to
c754ee9
Compare
lindnerby
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #1281
This PR address above issue by split diff resource during deletion, it trying to delete resources managed by module operator first, after those managed resources are deleted, then LM start to delete operator-related resources, e.g:
ServiceAccount,Role,ClusterRole,RoleBinding,ClusterRoleBinding. to ensure the module operator not being affected during deletion.