chore: Refactor ModuleTemplate catalog sync code #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Tomasz-Smelcerz-SAP
changed the title
Tomasz-Smelcerz-SAP
force-pushed
the
chore/refactor-catalog-sync
branch
from
16799f0 to
a42fb89
Compare
kyma-bot
added
size/XXL
Tomasz-Smelcerz-SAP
force-pushed
the
chore/refactor-catalog-sync
branch
from
191b131 to
59835a0
Compare
lindnerby
approved these changes
Nov 4, 2024
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor ModuleTemplate catalog sync code so that it's unit-testable and the entire CatalogSync can be easily extended to support synchronization for other types.
Changes proposed in this pull request:
Note for reviewer(s)
Surely more could be done in terms of code quality, e.g: separating the types to multiple packages.
This can be done in further iterations, and we'll have further iterations - we want to introduce a dedicated controller that performs the sync. At this moment I wanted the changes to be minimal to speed up the process (with respect to implementation and code review)
Related issue(s)
#1851