feat: Modulereleasemeta catalog sync #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Tomasz-Smelcerz-SAP
force-pushed
the
feat/modulereleasemeta-catalog-sync
branch
from
1516789 to
08010c4
Compare
nesmabadr
force-pushed
the
feat/modulereleasemeta-catalog-sync
branch
4 times, most recently
from
1b04052 to
61211d5
Compare
nesmabadr
force-pushed
the
feat/modulereleasemeta-catalog-sync
branch
from
61211d5 to
21fff25
Compare
nesmabadr
reviewed
Nov 6, 2024
…sz-Smelcerz-SAP/lifecycle-manager into feat/modulereleasemeta-catalog-sync
|
LGTM, but we are still missing the documentation here |
nesmabadr
previously approved these changes
Nov 7, 2024
…sz-Smelcerz-SAP/lifecycle-manager into feat/modulereleasemeta-catalog-sync
kyma-bot
added
size/XXL
nesmabadr
previously approved these changes
Nov 7, 2024
nesmabadr
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend existing remote catalog sync logic with support for
ModuleReleaseMetaobjects and corresponding CRD.Note for reviewer: The catalog sync code in the
internal/remotepackage requires refactoring to remove code duplication and improve it's internal structure. This is a work in progress that started already with PR: #2002For now, to add support for syncing
ModuleReleaseMeta, I tried to avoid big refactoring as much as possible.This package is already complex and adding massive refactoring on top of a new feature means that the PR would be very hard to review (and the risk of introducing errors would be significant)
This is why there's so much code duplication at the moment - it's easier to understand the new sync logic if it just re-uses the already tried approach.
This code will be refactored later in a dedicated refactoring issue: #2015
Changes proposed in this pull request:
internal/remotepackage with support forModuleReleaseMetaobjectsRelated issue(s)
#1851