Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add a new reason for the pipelines #1322

Merged
merged 3 commits into from
Aug 6, 2024
Merged

fix: Add a new reason for the pipelines #1322

merged 3 commits into from
Aug 6, 2024

Conversation

rakesh-garimella
Copy link
Contributor

Description

Changes proposed in this pull request (what was done and why):

  • Add a new reason RolloutInProgress when the pods are restarting or starting up

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@rakesh-garimella rakesh-garimella requested review from a team as code owners August 5, 2024 10:49
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Aug 5, 2024
@rakesh-garimella rakesh-garimella added kind/bug Categorizes issue or PR as related to a bug. and removed cla: yes Indicates the PR's author has signed the CLA. labels Aug 5, 2024
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 5, 2024
@rakesh-garimella rakesh-garimella added area/manager Manager or module changes and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 5, 2024
@rakesh-garimella rakesh-garimella added this to the 1.22.0 milestone Aug 5, 2024
NHingerl
NHingerl reviewed Aug 5, 2024
View reviewed changes
docs/user/resources/02-logpipeline.md Outdated Show resolved Hide resolved
docs/user/resources/04-tracepipeline.md Outdated Show resolved Hide resolved
docs/user/resources/05-metricpipeline.md Outdated Show resolved Hide resolved
docs/user/resources/05-metricpipeline.md Outdated Show resolved Hide resolved
@rakesh-garimella @NHingerl
Apply suggestions from code review
49bc372 
Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2024
skhalash
skhalash previously approved these changes Aug 6, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 6, 2024
@rakesh-garimella rakesh-garimella added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 6, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 6, 2024
@rakesh-garimella rakesh-garimella removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2024
@kyma-bot kyma-bot merged commit 7afedd0 into kyma-project:main Aug 6, 2024
35 checks passed
@rakesh-garimella rakesh-garimella deleted the fix-status branch August 6, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

@NHingerl NHingerl

Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rakesh-garimella @skhalash @NHingerl @kyma-bot