Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add a new reason for the pipelines #1322

Merged
merged 3 commits into from
Aug 6, 2024
Merged

fix: Add a new reason for the pipelines #1322

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddf6d1a
fix: Add a new reason for the pipelines
rakesh-garimella Aug 5, 2024
49bc372
Apply suggestions from code review
rakesh-garimella Aug 6, 2024
0556d37
fixes based on review comments
rakesh-garimella Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/user/resources/02-logpipeline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,12 @@ The status of the LogPipeline is determined by the condition types `AgentHealthy
| Condition Type | Condition Status | Condition Reason | Condition Message |
|------------------------|------------------|-----------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| AgentHealthy | True | AgentReady | Fluent Bit agent DaemonSet is ready |
| AgentHealthy | True | AgentReady | Pods are being started/updated |
| AgentHealthy | True | RolloutInProgress | Pods are being started/updated |
| AgentHealthy | False | AgentNotReady | No Pods deployed |
| AgentHealthy | False | AgentNotReady | DaemonSet is not yet created |
| AgentHealthy | False | AgentNotReady | Failed to get DaemonSet |
| AgentHealthy | False | AgentNotReady | Pod is in the pending state as container: `container name` is not running due to: `reason` |
| AgentHealthy | False | AgentNotReady | Pod is in the failed state due to: `reason` |
| AgentHealthy | False | AgentNotReady | Pod is in the pending state as container: `container name` is not running due to: `reason` |
rakesh-garimella marked this conversation as resolved.
Show resolved Hide resolved
| AgentHealthy | False | AgentNotReady | Pod is in the failed state due to: `reason` |
| ConfigurationGenerated | True | AgentConfigured | LogPipeline specification is successfully applied to the configuration of Fluent Bit agent |
| ConfigurationGenerated | True | TLSCertificateAboutToExpire | TLS (CA) certificate is about to expire, configured certificate is valid until YYYY-MM-DD |
| ConfigurationGenerated | False | ReferencedSecretMissing | One or more referenced Secrets are missing: Secret 'my-secret' of Namespace 'my-namespace' |
Expand Down
6 changes: 3 additions & 3 deletions docs/user/resources/04-tracepipeline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,13 @@ The status of the TracePipeline is determined by the condition types `GatewayHea
| Condition Type | Condition Status | Condition Reason | Condition Message |
|------------------------|------------------|-----------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| GatewayHealthy | True | GatewayReady | Trace gateway Deployment is ready |
| GatewayHealthy | True | GatewayReady | Pods are being started/updated |
| GatewayHealthy | True | RolloutInProgress | Pods are being started/updated |
| GatewayHealthy | False | GatewayNotReady | No Pods deployed |
| GatewayHealthy | False | GatewayNotReady | Failed to list ReplicaSets: `reason` |
| GatewayHealthy | False | GatewayNotReady | Failed to fetch ReplicaSets: `reason` |
| GatewayHealthy | False | GatewayNotReady | Pod is not scheduled: `reason` |
| GatewayHealthy | False | GatewayNotReady | Pod is in the pending state as container: `container name` is not running due to: `reason` |
| GatewayHealthy | False | GatewayNotReady | Pod is in the failed state due to: `reason` |
| GatewayHealthy | False | GatewayNotReady | Pod is in the pending state as container: `container name` is not running due to: `reason` |
rakesh-garimella marked this conversation as resolved.
Show resolved Hide resolved
| GatewayHealthy | False | GatewayNotReady | Pod is in the failed state due to: `reason` |
| GatewayHealthy | False | GatewayNotReady | Deployment is not yet created |
| GatewayHealthy | False | GatewayNotReady | Failed to get Deployment |
| GatewayHealthy | False | GatewayNotReady | Failed to get latest ReplicaSets |
Expand Down
12 changes: 6 additions & 6 deletions docs/user/resources/05-metricpipeline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,24 +179,24 @@ The status of the MetricPipeline is determined by the condition types `GatewayHe
| Condition Type | Condition Status | Condition Reason | Condition Message |
|------------------------|------------------|-----------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| GatewayHealthy | True | GatewayReady | Metric gateway Deployment is ready |
| GatewayHealthy | True | GatewayReady | Pods are being started/updated |
| GatewayHealthy | True | RolloutInProgress | Pods are being started/updated |
| GatewayHealthy | False | GatewayNotReady | No Pods deployed |
| GatewayHealthy | False | GatewayNotReady | Failed to list ReplicaSets: `reason` |
| GatewayHealthy | False | GatewayNotReady | Failed to fetch ReplicaSets: `reason` |
| GatewayHealthy | False | GatewayNotReady | Pod is not scheduled: `reason` |
| GatewayHealthy | False | GatewayNotReady | Pod is in the pending state as container: `container name` is not running due to: `reason` |
| GatewayHealthy | False | GatewayNotReady | Pod is in the failed state due to: `reason` |
| GatewayHealthy | False | GatewayNotReady | Pod is in the pending state as container: `container name` is not running due to: `reason` |
rakesh-garimella marked this conversation as resolved.
Show resolved Hide resolved
| GatewayHealthy | False | GatewayNotReady | Pod is in the failed state due to: `reason` |
| GatewayHealthy | False | GatewayNotReady | Deployment is not yet created |
| GatewayHealthy | False | GatewayNotReady | Failed to get Deployment |
| GatewayHealthy | False | GatewayNotReady | Failed to get latest ReplicaSets |
| AgentHealthy | True | AgentNotRequired | |
| AgentHealthy | True | AgentReady | Metric agent DaemonSet is ready |
| AgentHealthy | True | AgentReady | Pods are being started/updated |
| AgentHealthy | True | RolloutInProgress | Pods are being started/updated |
| AgentHealthy | False | AgentNotReady | No Pods deployed |
| AgentHealthy | False | AgentNotReady | DaemonSet is not yet created |
| AgentHealthy | False | AgentNotReady | Failed to get DaemonSet |
| AgentHealthy | False | AgentNotReady | Pod is in the pending state as container: `container name` is not running due to: `reason` |
| AgentHealthy | False | AgentNotReady | Pod is in the failed state due to: `reason` |
| AgentHealthy | False | AgentNotReady | Pod is in the pending state as container: `container name` is not running due to: `reason` |
rakesh-garimella marked this conversation as resolved.
Show resolved Hide resolved
| AgentHealthy | False | AgentNotReady | Pod is in the failed state due to: `reason` |
| ConfigurationGenerated | True | AgentGatewayConfigured | MetricPipeline specification is successfully applied to the configuration of Metric gateway |
| ConfigurationGenerated | True | TLSCertificateAboutToExpire | TLS (CA) certificate is about to expire, configured certificate is valid until YYYY-MM-DD |
| ConfigurationGenerated | False | MaxPipelinesExceeded | Maximum pipeline count limit exceeded |
Expand Down
1 change: 1 addition & 0 deletions internal/conditions/conditions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ const (
ReasonTLSConfigurationInvalid = "TLSConfigurationInvalid"
ReasonGatewayConfigured = "GatewayConfigured"
ReasonValidationFailed = "ValidationFailed"
ReasonRolloutInProgress = "RolloutInProgress"

// Telemetry reasons
ReasonComponentsRunning = "ComponentsRunning"
Expand Down
4 changes: 2 additions & 2 deletions internal/reconciler/commonstatus/checker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func GetGatewayHealthyCondition(ctx context.Context, prober DeploymentProber, na

if workloadstatus.IsRolloutInProgressError(err) {
status = metav1.ConditionTrue
reason = conditions.ReasonGatewayReady
reason = conditions.ReasonRolloutInProgress
msg = errToMsgCon.Convert(err)
}

Expand Down Expand Up @@ -80,7 +80,7 @@ func GetAgentHealthyCondition(ctx context.Context, prober DaemonSetProber, names
}
if workloadstatus.IsRolloutInProgressError(err) {
status = metav1.ConditionTrue
reason = conditions.ReasonAgentReady
reason = conditions.ReasonRolloutInProgress
msg = errToMsgCon.Convert(err)
}

Expand Down
Loading
Loading