Add Date as a valid return type for max and min
#1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igalklebanov
added
enhancement
|
Hey 👋 Thanks! 💪
|
…kysely-org#1085) * add reusable helpers recipe and implement missing expression features * force node 22.4.1 in CI because of an npm bug
* feat: add postgres range types (kysely-org#1086) * feat: support refresh naterialized view * fix tests by adding .materialized() to remove the matview * fix failing test * fix: References typo (kysely-org#1092) * chore: refresh-view-node.ts => refresh-materialized-view-node.ts * chore: export node in index.ts --------- Co-authored-by: Isak <16906089+kansson@users.noreply.github.com> Co-authored-by: Jonathan Wu <jonathanwu70@gmail.com>
Co-authored-by: Igal Klebanov <igal@grainfinance.co>
* feat: empty where in plugin * test: add new tests * chore: remove unneccesary typeguards * fix: change to binary operator node * test: update tests to do both in and not in * test: for having * chore: rm test * test: nullable tests * chore: nit * chore: condense suite * chore: db config override * chore: extra console log * chore: empty arr plugin docs * HandleEmptyInListsPlugin initial commit. Co-authored-by: Austin Woon Quan <43132101+austinwoon@users.noreply.github.com> --------- Co-authored-by: Austin Woon <austin@open.gov.sg> Co-authored-by: igalklebanov <igalklebanov@gmail.com>
Co-authored-by: Sam Clearman <238164+samclearman@users.noreply.github.com>
Co-authored-by: Sam Clearman <238164+samclearman@users.noreply.github.com>
Co-authored-by: Sam Clearman <238164+samclearman@users.noreply.github.com>
igalklebanov
added
mysql
|
Pushed this through the finish line. Thanks for raising this. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least with postgres / pg, it's possible for the value of a field generated by the
maxandminfunctions to be a Date. This PR updates the constraints on the types of these functions to reflect that.