[pull] dev from opf:dev #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
According to the rack timout documentation https://github.com/zombocom/rack-timeout/blob/main/doc/settings.md#service-timeout "Service timeout can be disabled entirely by setting the property to 0 or false" Limiting the service timeout to be active only in production enables debugging in dev and test env without fearing for the timeout to take oneself out of context.
When `PermittedParams#settings` was called, it was not permitting any params, which lead to "Unpermitted parameters: ..." messages being logged, and then merged the resulting empty params with the controller params after having filtered them manually. It was ok-ish but the logged error message was misleading. The `#settings` method was refactored to permit params that are allowed in a single step and avoid the misleading log messages.
Bumps [@ngx-formly/core](https://github.com/ngx-formly/ngx-formly) from 6.3.0 to 6.3.2. - [Release notes](https://github.com/ngx-formly/ngx-formly/releases) - [Changelog](https://github.com/ngx-formly/ngx-formly/blob/main/CHANGELOG.md) - [Commits](ngx-formly/ngx-formly@v6.3.0...v6.3.2) --- updated-dependencies: - dependency-name: "@ngx-formly/core" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [google-apis-gmail_v1](https://github.com/googleapis/google-api-ruby-client) from 0.40.0 to 0.41.0. - [Release notes](https://github.com/googleapis/google-api-ruby-client/releases) - [Changelog](https://github.com/googleapis/google-api-ruby-client/blob/main/generated/google-apis-gmail_v1/CHANGELOG.md) - [Commits](googleapis/google-api-ruby-client@0.40.0...0.41.0) --- updated-dependencies: - dependency-name: google-apis-gmail_v1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [webmock](https://github.com/bblimke/webmock) from 3.23.0 to 3.23.1. - [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md) - [Commits](bblimke/webmock@v3.23.0...v3.23.1) --- updated-dependencies: - dependency-name: webmock dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ev/ngx-formly/core-6.3.2 Bump @ngx-formly/core from 6.3.0 to 6.3.2 in /frontend
…-gmail_v1-0.41.0 Bump google-apis-gmail_v1 from 0.40.0 to 0.41.0
rack wait_timeout only in production
`ActionController::Parameters#permit` takes a list of filters. There is no kwargs argument. Co-authored-by: Klaus Zanders <k.zanders@openproject.com>
Bump webmock from 3.23.0 to 3.23.1
"attachment_whitelist" is normally permitted as an array parameter, but the form passes it as a string parameter to be split. This commit adds a way to also permit parameters such as "attachment_whitelist" as a string parameter.
Chore: avoid misleading "Unpermitted parameters: xxx" message log
Allow ProjectQuery to be marked as public
…error Makes sure jobs are eventually discarded when concurrency happens
Use shared_let and explicitly set user for `public_query`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )