-
-
Notifications
You must be signed in to change notification settings - Fork 154
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Call done() callback only on dev mode (#281)
- Loading branch information
Showing
1 changed file
with
5 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,10 +61,12 @@ gulp.task('build', done => { | |
// TODO: add remark-cli with -qfo options | ||
// TODO: ensure depcheck, xo, pug-lint, remark lint called in lint task | ||
runSequence('lint', 'css', ['img', 'js', 'static'], async () => { | ||
if (!PROD && config.openInBrowser) { | ||
await opn(config.urls.web, { wait: false }); | ||
if (PROD) { | ||
if (config.openInBrowser) { | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
pablopunk
Author
Contributor
|
||
await opn(config.urls.web, { wait: false }); | ||
} | ||
done(); | ||
} | ||
done(); | ||
}); | ||
}); | ||
|
||
|
I think this is a bug - you should simply have
if (config.env === 'development' && config.openInBrowser) {