Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add opn to open browser in gulp script upon start #281

Closed
niftylettuce opened this issue Sep 8, 2017 · 4 comments
Closed

feature: add opn to open browser in gulp script upon start #281

niftylettuce opened this issue Sep 8, 2017 · 4 comments
Assignees
@pablopunk
Labels
feature
Milestone
alpha-v1.0.0

Comments

@niftylettuce
Copy link
Collaborator

one time only when a user yarn start's it should use the opn package to run await opn(config.urls.web, { wait: false }); in template/gulpfile.js so that it opens the user's browser for them!
@niftylettuce
Copy link
Collaborator Author

also, this should only occur for development environment config.env === 'development'

@niftylettuce niftylettuce modified the milestone: alpha-v1.0.0 Sep 8, 2017
@pablopunk pablopunk self-assigned this Sep 8, 2017
pablopunk added a commit that referenced this issue Sep 8, 2017
@pablopunk
Open browser after the first gulp build (#281)
d22455d
@niftylettuce niftylettuce reopened this Sep 8, 2017
@OmgImAlexis
Copy link
Contributor

opn shouldn't run if nodemon hits an error.

I think we can use the nodemon api to check before running opn for the first time.

@pablopunk
Copy link
Contributor

Got it. I was out for the weekend I'll check it when I get home.

pablopunk added a commit that referenced this issue Sep 11, 2017
@pablopunk
Call done() callback only on dev mode (#281)
6faf274
pablopunk added a commit that referenced this issue Sep 12, 2017
@pablopunk
Specify development env (#281)
a4d6084
@pablopunk
Copy link
Contributor

Should we use gulp-nodemon to check for errors?

niftylettuce pushed a commit that referenced this issue Sep 13, 2019
@pablopunk
Open browser after the first gulp build (#281)
5ae3dd6
niftylettuce pushed a commit that referenced this issue Sep 13, 2019
@pablopunk
'Open in browser' is now optional (fix #281)
98f00df
niftylettuce pushed a commit that referenced this issue Sep 13, 2019
@pablopunk
Call done() callback only on dev mode (#281)
cc3ffa7
niftylettuce pushed a commit that referenced this issue Sep 13, 2019
@pablopunk
Specify development env (#281)
bee6285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pablopunk pablopunk

Labels
feature
Projects
None yet
Milestone
alpha-v1.0.0
Development

No branches or pull requests
3 participants
@niftylettuce @pablopunk @OmgImAlexis