Add test for old version Node #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1722 +/- ##
==========================================
+ Coverage 86.67% 86.76% +0.08%
==========================================
Files 14 14
Lines 1133 1133
==========================================
+ Hits 982 983 +1
+ Misses 151 150 -1
Continue to review full report at Codecov.
|
|
This broke my CI, I don't think this is a good change. |
|
Agreed |
|
v7.1.5 released to npm (note the tests are broken until someone rewrites them) https://github.com/visionmedia/superagent/releases/tag/v7.1.5 |
|
The fix has supplied. #1729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some version of development packages we used is not suitable for old version node. This packages include eslint commitlint husky remark-cli xo. I moved all these to optional dependencies . And now we can install dependencies via
yarn install --ignore-optionalto skip the installing of incompatible packages.And I also found the files in test folder can't been run on old version Node, so I transform them to ES5 files via bable.