Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the test for old Node #1729

Merged
merged 5 commits into from
Jun 8, 2022
Merged

Conversation

yunnysunny
Copy link
Contributor

  1. pre-commit use yarn lint-staged to check code validation, but it can not read configration of eslint properly. And yarn test include the npm script of lint. So I remove the yarn lint-staged from pre-commit.
  2. The lint script will fail to run in pre-commit on Windows, so I correct it.
  3. Re-enable the test for old Node by rewriting the package.json in CI.
  4. Rollback the dependencies of commitlint and husky to old version to make it run OK on Node 12.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2022

Codecov Report

Merging #1729 (18896ec) into master (3b1ff63) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
+ Coverage   94.09%   94.10%   +0.01%     
==========================================
  Files          14       14              
  Lines        1134     1137       +3     
==========================================
+ Hits         1067     1070       +3     
  Misses         67       67              
Impacted Files Coverage Δ
src/request-base.js 93.06% <ø> (ø)
src/node/index.js 93.66% <100.00%> (+0.02%) ⬆️
src/node/parsers/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f043a8...18896ec. Read the comment docs.

@titanism titanism merged commit 26c72d0 into ladjs:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants