-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm32 support #828
Wasm32 support #828
Conversation
61c9f64
to
8889b75
Compare
8889b75
to
21cf0b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tdelabro. Overall it looks good. I left a few comments and questions tho, let me know what you think.
Codecov Report
@@ Coverage Diff @@
## main #828 +/- ##
==========================================
- Coverage 97.47% 97.42% -0.06%
==========================================
Files 69 69
Lines 29049 29120 +71
==========================================
+ Hits 28315 28369 +54
- Misses 734 751 +17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b0c18d6
to
6ddeb09
Compare
d56107a
to
1188716
Compare
b31df5f
to
ceb0808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the other comments, an important question. Is the wasm version expected to generate traces or just execute and retrieve the output? If it's the latter, we can keep a sizable chunk of the code as is (specially the parts that would use much more memory) by just avoiding compiling them for nostd.
That's up to you. Versions of the form |
cd160db
to
ebeae18
Compare
I picked |
I think we do. Imagine running a program in the user browser, generating the trace, sending it to the verifier, and getting the proof back. All in a web app, only running on the user's machine |
c3c8c84
to
18a6641
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last round of changes and it's done.
Please don't use git commit --amend
or git rebase
. We'll squash it on merge so it doesn't make a difference history-wise and it breaks GitHub making it impossible to see changes from the last review. This means reviewers need to go through all the changes again to find what changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎉 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!!
wasm support
Description
This pr introduces wasm support for cairo-rs. Aka a new compilation target.
It also adds the
std
feature, present by default. And the possibility to remove it to compile a slightly differentno_std
binary