Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM32 support with regression fix #893

Merged
merged 5 commits into from
Mar 14, 2023
Merged

WASM32 support with regression fix #893

merged 5 commits into from
Mar 14, 2023

Conversation

Oppen
Copy link
Contributor

@Oppen Oppen commented Mar 10, 2023

This reverts commit 23d941f and applies the following changes on top to fix a performance regression caused by the previously reverted commit:

  • Re-add support for mimalloc to the new subproject that creates the runnable;
  • Use a larger buffer for writing the memory and execution traces (5MiB and 3MiB respectively, so a whole number of fields fit between flushes);
  • Extend IAI benchmarks a bit to consider these writes.

Co-authored-by: @tdelabro

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #893 (c7e2d37) into main (e32e435) will decrease coverage by 0.08%.
The diff coverage is 88.17%.

@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
- Coverage   97.47%   97.39%   -0.08%     
==========================================
  Files          69       69              
  Lines       29071    29142      +71     
==========================================
+ Hits        28336    28382      +46     
- Misses        735      760      +25     
Impacted Files Coverage Δ
cairo-vm-cli/src/main.rs 25.77% <0.00%> (ø)
...t_processor/builtin_hint_processor/blake2s_hash.rs 100.00% <ø> (ø)
..._processor/builtin_hint_processor/blake2s_utils.rs 99.74% <ø> (ø)
...int_processor/builtin_hint_processor_definition.rs 98.69% <ø> (ø)
...uiltin_hint_processor/cairo_keccak/keccak_hints.rs 93.91% <ø> (ø)
...rocessor/builtin_hint_processor/dict_hint_utils.rs 99.23% <ø> (+<0.01%) ⬆️
...t_processor/builtin_hint_processor/dict_manager.rs 96.73% <ø> (ø)
...int_processor/builtin_hint_processor/hint_utils.rs 94.59% <ø> (ø)
...t_processor/builtin_hint_processor/keccak_utils.rs 100.00% <ø> (ø)
...int_processor/builtin_hint_processor/math_utils.rs 97.95% <ø> (-0.01%) ⬇️
... and 58 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen force-pushed the wasm_support_mark_2 branch from 8d1368a to b2cfdab Compare March 10, 2023 18:11
@Oppen Oppen force-pushed the wasm_support_mark_2 branch from 2898777 to 6788ca0 Compare March 13, 2023 20:52
@Oppen Oppen changed the title Revert "Revert "Wasm32 support (#828)" (#891)" WASM32 support with regression fix Mar 14, 2023
@Oppen Oppen marked this pull request as ready for review March 14, 2023 19:24
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oppen Oppen added this pull request to the merge queue Mar 14, 2023
Merged via the queue into main with commit cfeac09 Mar 14, 2023
@Oppen Oppen deleted the wasm_support_mark_2 branch March 14, 2023 21:27
@tdelabro
Copy link
Contributor

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants