-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASM32 support with regression fix #893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #893 +/- ##
==========================================
- Coverage 97.47% 97.39% -0.08%
==========================================
Files 69 69
Lines 29071 29142 +71
==========================================
+ Hits 28336 28382 +46
- Misses 735 760 +25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
force-pushed
the
wasm_support_mark_2
branch
from
March 10, 2023 18:11
8d1368a
to
b2cfdab
Compare
Oppen
force-pushed
the
wasm_support_mark_2
branch
from
March 13, 2023 20:52
2898777
to
6788ca0
Compare
Oppen
changed the title
Revert "Revert "Wasm32 support (#828)" (#891)"
WASM32 support with regression fix
Mar 14, 2023
Oppen
requested review from
igaray,
fmoletta,
entropidelic,
HermanObst,
juanbono,
Jrigada,
pefontana and
Juan-M-V
as code owners
March 14, 2023 19:24
fmoletta
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
igaray
approved these changes
Mar 14, 2023
juanbono
approved these changes
Mar 14, 2023
🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 23d941f and applies the following changes on top to fix a performance regression caused by the previously reverted commit:
Co-authored-by: @tdelabro