fix: update starknet-crypto (#1088)

Update to 0.5.0 to include the fix for a `panic` in
`starknet_crypto::ecdsa::verify`

Use release mode for wasm tests, since the update triggers a 'too many
locals' error otherwise

.github/workflows/rust.yml

@@ -167,7 +167,7 @@ jobs:
       with:
         tool: cargo-nextest,cargo-llvm-cov,wasm-pack
     - name: Run
-      run:
+      run: |
         # FIXME: we need to update the Makefile to do this correctly
         case ${{ matrix.target }} in
         'test')
@@ -177,7 +177,8 @@ jobs:
           cargo llvm-cov nextest --lcov --output-path lcov-${{ matrix.target }}.info --workspace --features test_utils --no-default-features
           ;;
         'test-wasm')
-          wasm-pack test --node --no-default-features
+          # NOTE: release mode is needed to avoid "too many locals" error
+          wasm-pack test --release --node --no-default-features
           ;;
         esac
 

CHANGELOG.md

@@ -142,6 +142,10 @@
     %}
     ```
 
+* fix(starknet-crypto): bump version to `0.5.0` [#1088](https://github.com/lambdaclass/cairo-rs/pull/1088)
+    * This includes the fix for a `panic!` in `ecdsa::verify`.
+      See: [#365](https://github.com/xJonathanLEI/starknet-rs/issues/365) and [#366](https://github.com/xJonathanLEI/starknet-rs/pulls/366)
+
 * feat(hints): Add alternative string for hint IS_ZERO_PACK [#1081](https://github.com/lambdaclass/cairo-rs/pull/1081)
 
     `BuiltinHintProcessor` now supports the following hint:

Cargo.toml

@@ -49,7 +49,7 @@ hex = { version = "0.4.3", default-features = false }
 bincode = { version = "2.0.0-rc.2", tag = "v2.0.0-rc.2", git = "https://github.com/bincode-org/bincode.git", default-features = false, features = [
     "serde",
 ] }
-starknet-crypto = { version = "0.4.3", default-features = false, features = [
+starknet-crypto = { version = "0.5.0", default-features = false, features = [
     "signature-display",
     "alloc",
 ] }

Makefile

@@ -146,7 +146,8 @@ test: $(COMPILED_PROOF_TESTS) $(COMPILED_TESTS) $(COMPILED_BAD_TESTS) $(COMPILED
 test-no_std: $(COMPILED_PROOF_TESTS) $(COMPILED_TESTS) $(COMPILED_BAD_TESTS) $(COMPILED_NORETROCOMPAT_TESTS)
 	cargo llvm-cov nextest --no-report --workspace --features test_utils --no-default-features
 test-wasm: $(COMPILED_PROOF_TESTS) $(COMPILED_TESTS) $(COMPILED_BAD_TESTS) $(COMPILED_NORETROCOMPAT_TESTS)
-	wasm-pack test --node --no-default-features
+	# NOTE: release mode is needed to avoid "too many locals" error
+	wasm-pack test --release --node --no-default-features
 
 clippy:
 	cargo clippy --all --all-features --benches --examples --tests -- -D warnings