Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update starknet-crypto #1088

Merged
merged 1 commit into from
Apr 30, 2023
Merged

fix: update starknet-crypto #1088

merged 1 commit into from
Apr 30, 2023

Conversation

Oppen
Copy link
Contributor

@Oppen Oppen commented Apr 27, 2023

Update to 0.5.0 to include the fix for a panic in starknet_crypto::ecdsa::verify

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@Oppen Oppen force-pushed the fix/update_starknet-rs branch from 9006906 to 0ece514 Compare April 27, 2023 19:28
@Oppen Oppen marked this pull request as ready for review April 27, 2023 19:28
@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 2.502 ± 0.029 2.478 2.558 1.01 ± 0.01
head blake2s_integration_benchmark 2.482 ± 0.021 2.459 2.519 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.097 ± 0.041 3.054 3.174 1.01 ± 0.03
head compare_arrays_200000 3.056 ± 0.066 3.021 3.240 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.444 ± 0.018 2.414 2.479 1.02 ± 0.01
head dict_integration_benchmark 2.403 ± 0.007 2.390 2.413 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 3.713 ± 0.024 3.692 3.777 1.00
head factorial_multirun 3.764 ± 0.027 3.734 3.825 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.006 ± 0.018 2.980 3.043 1.00 ± 0.02
head fibonacci_1000_multirun 2.995 ± 0.046 2.959 3.107 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 133.4 ± 4.6 129.8 144.1 1.03 ± 0.04
head field_arithmetic_get_square_benchmark 129.3 ± 1.1 127.6 131.0 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 2.956 ± 0.034 2.927 3.042 1.00 ± 0.01
head integration_builtins 2.944 ± 0.012 2.926 2.962 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 2.688 ± 0.016 2.672 2.722 1.01 ± 0.01
head keccak_integration_benchmark 2.666 ± 0.011 2.651 2.686 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.183 ± 0.014 3.169 3.218 1.00 ± 0.02
head linear_search 3.171 ± 0.072 3.122 3.353 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.714 ± 0.014 2.694 2.735 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 2.698 ± 0.029 2.669 2.778 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.504 ± 0.015 2.487 2.539 1.00
head math_integration_benchmark 2.506 ± 0.030 2.485 2.586 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.158 ± 0.020 2.135 2.203 1.01 ± 0.01
head memory_integration_benchmark 2.132 ± 0.020 2.116 2.184 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.236 ± 0.014 2.226 2.272 1.01 ± 0.01
head operations_with_data_structures_benchmarks 2.218 ± 0.021 2.201 2.272 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 782.3 ± 4.0 777.1 792.0 1.00
head pedersen 817.5 ± 2.5 813.6 821.1 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.528 ± 0.028 1.511 1.605 1.00
head poseidon_integration_benchmark 1.615 ± 0.006 1.607 1.625 1.06 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.365 ± 0.007 2.358 2.377 1.00
head secp_integration_benchmark 2.374 ± 0.012 2.362 2.404 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.682 ± 0.005 1.675 1.688 1.00
head set_integration_benchmark 1.685 ± 0.007 1.675 1.694 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 3.930 ± 0.014 3.908 3.949 1.01 ± 0.00
head uint256_integration_benchmark 3.894 ± 0.010 3.879 3.908 1.00

@Oppen Oppen force-pushed the fix/update_starknet-rs branch 3 times, most recently from 44e271f to c0c8843 Compare April 29, 2023 05:38
Update to 0.5.0 to include the fix for a `panic` in
`starknet_crypto::ecdsa::verify`

Use release mode for wasm tests, since the update triggers a 'too many
locals' error otherwise
@Oppen Oppen force-pushed the fix/update_starknet-rs branch from c0c8843 to 62a57f7 Compare April 29, 2023 05:41
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #1088 (62a57f7) into main (eaea41f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1088   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files          85       85           
  Lines       34576    34576           
=======================================
  Hits        33934    33934           
  Misses        642      642           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen added this pull request to the merge queue Apr 30, 2023
Merged via the queue into main with commit 534acf8 Apr 30, 2023
@Oppen Oppen deleted the fix/update_starknet-rs branch April 30, 2023 20:41
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
Update to 0.5.0 to include the fix for a `panic` in
`starknet_crypto::ecdsa::verify`

Use release mode for wasm tests, since the update triggers a 'too many
locals' error otherwise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants