-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newhint#17 & Newhint#18 imports of SECP256R1_ALPHA and SECP256R1_N #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfachal
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
April 21, 2023 19:31
Benchmark Results for unmodified programs 🚀
|
Oppen
approved these changes
Apr 21, 2023
Codecov Report
@@ Coverage Diff @@
## main #1026 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 84 84
Lines 33837 33867 +30
=======================================
+ Hits 33192 33222 +30
Misses 645 645
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fmoletta
reviewed
Apr 24, 2023
fmoletta
reviewed
Apr 24, 2023
pefontana
added
the
whitelisted-hint
Implementation of hint on whitelist directory
label
Apr 24, 2023
…ro-rs into newhint17-newhint18-imports
Oppen
approved these changes
Apr 25, 2023
juanbono
reviewed
Apr 25, 2023
juanbono
requested changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review @fmoletta comment
juanbono
approved these changes
Apr 26, 2023
Oppen
reviewed
Apr 26, 2023
Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
fmoletta
approved these changes
Apr 26, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
…ambdaclass#1026) * WIP newhint#17 and newhint#18 * WIP cairo program * add secp256r1 testing programs and newhint#17 and lambdaclass#18 * update changelog * remove program using unimplemented hint * add correct constants to test program * fix broken test when executing hint lambdaclass#25 with different context * Update CHANGELOG.md Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> * merge * add unit test for import alpha --------- Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
Add hints #17 and #18: IMPORT_SECP256R1_ALPHA and IMPORT_SECP256R1_N
Checklist