-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hints): add NewHint#19 #1057
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
added
the
whitelisted-hint
Implementation of hint on whitelist directory
label
Apr 25, 2023
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
April 25, 2023 22:07
Oppen
approved these changes
Apr 25, 2023
Benchmark Results for unmodified programs 🚀
|
Oppen
reviewed
Apr 26, 2023
Oppen
approved these changes
Apr 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #1057 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 84 84
Lines 33867 33926 +59
=======================================
+ Hits 33222 33281 +59
Misses 645 645
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pefontana
approved these changes
Apr 26, 2023
fmoletta
approved these changes
Apr 26, 2023
MegaRedHand
force-pushed
the
newhint19-double_slope_external_consts
branch
from
April 27, 2023 13:30
f314977
to
85ab196
Compare
Rebased onto main after merge of #1026 |
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add NewHint#19 * Update changelog * Allow trailing commas in check_scope macro * Fix: was trying to get BigUint from exec_scopes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #1026Description
This PR adds the missing hint NewHint#19, now known as
EC_DOUBLE_SLOPE_EXTERNAL_CONSTS
.