Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile ensure-no_std in CI for new lambdaworks backend #1293

Merged
merged 8 commits into from
Jun 28, 2023
Merged

Compile ensure-no_std in CI for new lambdaworks backend #1293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
70265f9
Ensure no-std for new lambdaworks backend
MegaRedHand Jun 27, 2023
e881d24
Fix: use correct matrix var name in job
MegaRedHand Jun 27, 2023
2587b4b
Remove --release flag in ensure-no_std build
MegaRedHand Jun 27, 2023
c38ab4e
Update lambdaworks to fix-no-std commit
MegaRedHand Jun 28, 2023
d6eb7e6
Update commit to main
MegaRedHand Jun 28, 2023
33eba6b
Merge branch 'main' into fix-nostd-lwfelt
MegaRedHand Jun 28, 2023
5d4099c
Bump lambdaworks-math version
MegaRedHand Jun 28, 2023
3b7be30
Update changelog
MegaRedHand Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,15 @@ jobs:
- name: Check no-std
run: |
cd ensure-no_std
cargo build --release
cargo build --no-default-features
cargo build

tests:
needs: build-programs
strategy:
fail-fast: false
matrix:
special-features: ["", "lambdaworks-felt"]
special_features: ["", "lambdaworks-felt"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is ok that you also changed the underscore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This was, in fact, a typo in the original PR. The typo was causing the CI to run tests without the lambdaworks-felt feature.

target: [ test, test-no_std, test-wasm ]
# TODO: features
name: Run tests
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#### Upcoming Changes

* fix: bump *lambdaworks-math* to latest version, that fixes no-std support [#1293](https://github.com/lambdaclass/cairo-vm/pull/1293)

* build: remove dependecy to `thiserror` (use `thiserror-no-std/std` instead)

* chore: use LambdaWorks' implementation of bit operations for `Felt252` [#1291](https://github.com/lambdaclass/cairo-rs/pull/1291)
Expand Down
118 changes: 53 additions & 65 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions ensure-no_std/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ cairo-vm = { path = "../vm", default-features = false }

wee_alloc = "0.4.5"

[features]
default = ["lambdaworks-felt"]
lambdaworks-felt = ["cairo-felt/lambdaworks-felt"]


[profile.dev]
panic = "abort"
Expand Down
2 changes: 1 addition & 1 deletion felt/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ lazy_static = { version = "1.4.0", default-features = false, features = [
"spin_no_std",
] }
serde = { version = "1.0", features = ["derive"], default-features = false }
lambdaworks-math = { version = "0.1.1", default-features = false, optional = true }
lambdaworks-math = { version = "0.1.2", default-features = false, optional = true }

[dev-dependencies]
proptest = "1.1.0"
Expand Down