-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile ensure-no_std
in CI for new lambdaworks backend
#1293
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
+ Coverage 97.56% 97.94% +0.37%
==========================================
Files 90 89 -1
Lines 36260 35452 -808
==========================================
- Hits 35377 34723 -654
+ Misses 883 729 -154 see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark Results for unmodified programs 🚀
|
|
||
tests: | ||
needs: build-programs | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
special-features: ["", "lambdaworks-felt"] | ||
special_features: ["", "lambdaworks-felt"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is ok that you also changed the underscore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This was, in fact, a typo in the original PR. The typo was causing the CI to run tests without the lambdaworks-felt
feature.
…s#1293) * Ensure no-std for new lambdaworks backend * Fix: use correct matrix var name in job * Remove --release flag in ensure-no_std build * Update lambdaworks to fix-no-std commit * Update commit to main * Bump lambdaworks-math version * Update changelog
…s#1293) * Ensure no-std for new lambdaworks backend * Fix: use correct matrix var name in job * Remove --release flag in ensure-no_std build * Update lambdaworks to fix-no-std commit * Update commit to main * Bump lambdaworks-math version * Update changelog
…s#1293) * Ensure no-std for new lambdaworks backend * Fix: use correct matrix var name in job * Remove --release flag in ensure-no_std build * Update lambdaworks to fix-no-std commit * Update commit to main * Bump lambdaworks-math version * Update changelog
…s#1293) * Ensure no-std for new lambdaworks backend * Fix: use correct matrix var name in job * Remove --release flag in ensure-no_std build * Update lambdaworks to fix-no-std commit * Update commit to main * Bump lambdaworks-math version * Update changelog
Description
Description of the pull request changes and motivation.
Checklist