Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile ensure-no_std in CI for new lambdaworks backend #1293

Merged
merged 8 commits into from
Jun 28, 2023

Conversation

MegaRedHand
Copy link
Contributor

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1293 (3b7be30) into main (fde54b4) will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
+ Coverage   97.56%   97.94%   +0.37%     
==========================================
  Files          90       89       -1     
  Lines       36260    35452     -808     
==========================================
- Hits        35377    34723     -654     
+ Misses        883      729     -154     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 11.300 ± 0.018 11.281 11.338 1.00 ± 0.00
head blake2s_integration_benchmark 11.258 ± 0.007 11.248 11.269 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.989 ± 0.007 3.974 3.999 1.00 ± 0.00
head compare_arrays_200000 3.983 ± 0.013 3.970 4.007 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.632 ± 0.008 2.621 2.649 1.00
head dict_integration_benchmark 2.640 ± 0.008 2.624 2.654 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 4.276 ± 0.010 4.259 4.294 1.00 ± 0.00
head factorial_multirun 4.266 ± 0.014 4.255 4.304 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.652 ± 0.008 3.644 3.665 1.00 ± 0.00
head fibonacci_1000_multirun 3.645 ± 0.009 3.635 3.667 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.958 ± 0.004 1.954 1.969 1.00
head field_arithmetic_get_square_benchmark 1.962 ± 0.007 1.952 1.976 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 10.135 ± 0.052 10.106 10.279 1.00 ± 0.01
head integration_builtins 10.109 ± 0.037 10.079 10.211 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 11.426 ± 0.045 11.391 11.541 1.00 ± 0.00
head keccak_integration_benchmark 11.424 ± 0.018 11.401 11.448 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.999 ± 0.013 3.987 4.026 1.00 ± 0.00
head linear_search 3.988 ± 0.010 3.974 4.012 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.864 ± 0.005 2.859 2.873 1.00
head math_cmp_and_pow_integration_benchmark 2.867 ± 0.007 2.859 2.877 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.601 ± 0.009 2.592 2.616 1.00
head math_integration_benchmark 2.612 ± 0.006 2.605 2.621 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.288 ± 0.007 2.276 2.298 1.00 ± 0.00
head memory_integration_benchmark 2.286 ± 0.007 2.274 2.297 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.545 ± 0.005 2.539 2.553 1.00 ± 0.00
head operations_with_data_structures_benchmarks 2.544 ± 0.006 2.538 2.558 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 860.2 ± 1.4 857.2 862.0 1.00
head pedersen 862.1 ± 1.3 860.8 864.8 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.570 ± 0.005 1.563 1.577 1.00 ± 0.00
head poseidon_integration_benchmark 1.569 ± 0.002 1.564 1.573 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.026 ± 0.006 3.017 3.035 1.00 ± 0.00
head secp_integration_benchmark 3.013 ± 0.005 3.006 3.021 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.542 ± 0.004 1.538 1.552 1.00 ± 0.01
head set_integration_benchmark 1.537 ± 0.010 1.531 1.562 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 7.293 ± 0.016 7.272 7.320 1.00
head uint256_integration_benchmark 7.319 ± 0.038 7.273 7.384 1.00 ± 0.01

@MegaRedHand MegaRedHand marked this pull request as ready for review June 28, 2023 18:14
@MegaRedHand MegaRedHand added this pull request to the merge queue Jun 28, 2023

tests:
needs: build-programs
strategy:
fail-fast: false
matrix:
special-features: ["", "lambdaworks-felt"]
special_features: ["", "lambdaworks-felt"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is ok that you also changed the underscore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This was, in fact, a typo in the original PR. The typo was causing the CI to run tests without the lambdaworks-felt feature.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 28, 2023
@MegaRedHand MegaRedHand added this pull request to the merge queue Jun 28, 2023
@MegaRedHand MegaRedHand removed this pull request from the merge queue due to a manual request Jun 28, 2023
@MegaRedHand MegaRedHand added this pull request to the merge queue Jun 28, 2023
Merged via the queue into main with commit 05f2f4a Jun 28, 2023
@MegaRedHand MegaRedHand deleted the fix-nostd-lwfelt branch June 28, 2023 19:51
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 4, 2023
…s#1293)

* Ensure no-std for new lambdaworks backend

* Fix: use correct matrix var name in job

* Remove --release flag in ensure-no_std build

* Update lambdaworks to fix-no-std commit

* Update commit to main

* Bump lambdaworks-math version

* Update changelog
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 4, 2023
…s#1293)

* Ensure no-std for new lambdaworks backend

* Fix: use correct matrix var name in job

* Remove --release flag in ensure-no_std build

* Update lambdaworks to fix-no-std commit

* Update commit to main

* Bump lambdaworks-math version

* Update changelog
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
…s#1293)

* Ensure no-std for new lambdaworks backend

* Fix: use correct matrix var name in job

* Remove --release flag in ensure-no_std build

* Update lambdaworks to fix-no-std commit

* Update commit to main

* Bump lambdaworks-math version

* Update changelog
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
…s#1293)

* Ensure no-std for new lambdaworks backend

* Fix: use correct matrix var name in job

* Remove --release flag in ensure-no_std build

* Update lambdaworks to fix-no-std commit

* Update commit to main

* Bump lambdaworks-math version

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants