Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix string code of BLAKE2S_ADD_UINT256 hint #1454

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Oct 3, 2023

Fixes small bug in the hint string that causes the match to fail when calling the common library function that uses the hint

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@fmoletta fmoletta marked this pull request as ready for review October 3, 2023 19:21
@fmoletta fmoletta added the bug Something isn't working label Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1454 (ec18b29) into main (77f4d2c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1454   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files          93       93           
  Lines       38791    38791           
=======================================
  Hits        37624    37624           
  Misses       1167     1167           
Files Coverage Δ
..._processor/builtin_hint_processor/blake2s_utils.rs 99.77% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 5.087 ± 0.089 5.008 5.310 1.01 ± 0.02
head big_factorial 5.061 ± 0.045 4.996 5.117 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 4.292 ± 0.057 4.223 4.422 1.00
head big_fibonacci 4.401 ± 0.107 4.286 4.651 1.03 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 11.406 ± 0.094 11.271 11.538 1.00 ± 0.01
head blake2s_integration_benchmark 11.380 ± 0.091 11.254 11.558 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.226 ± 0.044 4.138 4.289 1.00
head compare_arrays_200000 4.272 ± 0.081 4.183 4.432 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.861 ± 0.048 2.816 2.961 1.01 ± 0.02
head dict_integration_benchmark 2.838 ± 0.036 2.791 2.899 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.879 ± 0.017 1.843 1.904 1.00
head field_arithmetic_get_square_benchmark 1.918 ± 0.037 1.864 1.973 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 11.116 ± 0.103 10.974 11.283 1.00
head integration_builtins 11.127 ± 0.036 11.081 11.206 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 11.620 ± 0.070 11.452 11.711 1.00 ± 0.01
head keccak_integration_benchmark 11.610 ± 0.068 11.512 11.732 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.208 ± 0.051 4.139 4.287 1.01 ± 0.01
head linear_search 4.177 ± 0.035 4.141 4.239 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.067 ± 0.044 2.999 3.129 1.00
head math_cmp_and_pow_integration_benchmark 3.075 ± 0.030 3.038 3.122 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.777 ± 0.030 2.724 2.818 1.00 ± 0.02
head math_integration_benchmark 2.767 ± 0.043 2.725 2.875 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.511 ± 0.038 2.449 2.568 1.01 ± 0.02
head memory_integration_benchmark 2.477 ± 0.035 2.437 2.530 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.672 ± 0.027 2.629 2.711 1.01 ± 0.01
head operations_with_data_structures_benchmarks 2.636 ± 0.025 2.608 2.684 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 963.5 ± 8.4 953.3 978.2 1.00
head pedersen 978.3 ± 17.5 963.1 1020.5 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.843 ± 0.029 1.803 1.899 1.01 ± 0.02
head poseidon_integration_benchmark 1.830 ± 0.012 1.813 1.854 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.615 ± 0.035 3.570 3.699 1.00 ± 0.01
head secp_integration_benchmark 3.614 ± 0.017 3.592 3.649 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.276 ± 0.023 2.242 2.304 1.02 ± 0.02
head set_integration_benchmark 2.234 ± 0.032 2.208 2.304 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 7.267 ± 0.117 7.135 7.443 1.02 ± 0.02
head uint256_integration_benchmark 7.157 ± 0.052 7.088 7.238 1.00

@Oppen Oppen added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit c2f33eb Oct 3, 2023
45 checks passed
@Oppen Oppen deleted the fix-blake-hint branch October 3, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants